From: Kirill Tkhai <ktkhai@parallels.com>
To: <linux-kernel@vger.kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>, <tkhai@yandex.ru>
Subject: [PATCH 4/5] sched/rt: Remove useless if from cleanup pick_next_task_rt()
Date: Fri, 12 Sep 2014 17:42:01 +0400 [thread overview]
Message-ID: <1410529321.3569.26.camel@tkhai> (raw)
In-Reply-To: <20140912132709.26840.4893.stgit@tkhai>
_pick_next_task_rt() never returns NULL.
Signed-off-by: Kirill Tkhai <ktkhai@parallels.com>
---
kernel/sched/rt.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/kernel/sched/rt.c b/kernel/sched/rt.c
index 4feac8f..2e6a774 100644
--- a/kernel/sched/rt.c
+++ b/kernel/sched/rt.c
@@ -1468,8 +1468,7 @@ pick_next_task_rt(struct rq *rq, struct task_struct *prev)
p = _pick_next_task_rt(rq);
/* The running task is never eligible for pushing */
- if (p)
- dequeue_pushable_task(rq, p);
+ dequeue_pushable_task(rq, p);
set_post_schedule(rq);
next prev parent reply other threads:[~2014-09-12 13:42 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20140912132709.26840.4893.stgit@tkhai>
2014-09-12 13:40 ` [PATCH 1/5] cleanup, treewide: Remove set_current_state(TASK_RUNNING) after schedule Kirill Tkhai
2014-09-19 11:44 ` [tip:sched/core] sched, cleanup, treewide: Remove set_current_state(TASK_RUNNING) after schedule() tip-bot for Kirill Tkhai
2014-09-12 13:41 ` [PATCH 2/5] sched/fair: cleanup: Remove useless assignment in select_task_rq_fair() Kirill Tkhai
2014-09-19 11:45 ` [tip:sched/core] " tip-bot for Kirill Tkhai
2014-09-12 13:41 ` [PATCH 3/5] sched/core: Use put_prev_task() accessor where possible Kirill Tkhai
2014-09-19 11:45 ` [tip:sched/core] " tip-bot for Kirill Tkhai
2014-09-12 13:42 ` Kirill Tkhai [this message]
2014-09-19 11:45 ` [tip:sched/core] sched/rt: Remove useless if from cleanup pick_next_task_rt() tip-bot for Kirill Tkhai
2014-09-12 13:42 ` [PATCH 5/5] sched/dl: Simplify pick_dl_task() Kirill Tkhai
2014-09-19 11:46 ` [tip:sched/core] " tip-bot for Kirill Tkhai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1410529321.3569.26.camel@tkhai \
--to=ktkhai@parallels.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=tkhai@yandex.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox