public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Valentin Rothberg <valentinrothberg@gmail.com>
To: akpm@linux-foundation.org, linux-kernel@vger.kernel.org
Cc: pebolle@tiscali.nl, Valentin Rothberg <valentinrothberg@gmail.com>
Subject: [PATCH] lib: rename TEST_MODULE to TEST_LKM
Date: Tue, 23 Sep 2014 08:58:28 +0200	[thread overview]
Message-ID: <1411455508-11958-1-git-send-email-valentinrothberg@gmail.com> (raw)

The "_MODULE" suffix is reserved for tristates compiled as
loadable kernel modules (LKM). The "TEST_MODULE" feature thereby
violates this convention. The feature is used to compile the
lib/test_module.c kernel module.

This patch renames the feature and its reference in a Makefile
to "TEST_LKM", which still expresses the test of a LKM.

Signed-off-by: Valentin Rothberg <valentinrothberg@gmail.com>
---
 lib/Kconfig.debug | 2 +-
 lib/Makefile      | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
index 07c2832..db91c97 100644
--- a/lib/Kconfig.debug
+++ b/lib/Kconfig.debug
@@ -1627,7 +1627,7 @@ config DMA_API_DEBUG
 
 	  If unsure, say N.
 
-config TEST_MODULE
+config TEST_LKM
 	tristate "Test module loading with 'hello world' module"
 	default n
 	depends on m
diff --git a/lib/Makefile b/lib/Makefile
index d6b4bc4..382437a 100644
--- a/lib/Makefile
+++ b/lib/Makefile
@@ -31,7 +31,7 @@ obj-y += string_helpers.o
 obj-$(CONFIG_TEST_STRING_HELPERS) += test-string_helpers.o
 obj-y += kstrtox.o
 obj-$(CONFIG_TEST_KSTRTOX) += test-kstrtox.o
-obj-$(CONFIG_TEST_MODULE) += test_module.o
+obj-$(CONFIG_TEST_LKM) += test_module.o
 obj-$(CONFIG_TEST_USER_COPY) += test_user_copy.o
 obj-$(CONFIG_TEST_BPF) += test_bpf.o
 obj-$(CONFIG_TEST_FIRMWARE) += test_firmware.o
-- 
1.9.1


             reply	other threads:[~2014-09-23  6:58 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-23  6:58 Valentin Rothberg [this message]
2014-09-23 16:49 ` [PATCH] lib: rename TEST_MODULE to TEST_LKM Randy Dunlap
2014-09-23 17:10   ` Valentin Rothberg
2014-09-23 17:11     ` Randy Dunlap
2014-09-23 18:27       ` Valentin Rothberg
2014-09-29 20:18         ` Paul Bolle
2014-09-29 20:25           ` Valentin Rothberg
2014-09-29 20:36             ` Paul Bolle
2014-09-29 21:02               ` Kees Cook
2014-09-29 21:05             ` Kees Cook

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1411455508-11958-1-git-send-email-valentinrothberg@gmail.com \
    --to=valentinrothberg@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pebolle@tiscali.nl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox