* [PATCH] ARC: [plat-arcfpga]: remove unused Kconfig params
@ 2014-10-01 9:59 Michael Opdenacker
2014-10-01 10:12 ` Paul Bolle
0 siblings, 1 reply; 3+ messages in thread
From: Michael Opdenacker @ 2014-10-01 9:59 UTC (permalink / raw)
To: vgupta; +Cc: richard, pebolle, gregkh, linux-kernel, Michael Opdenacker
This removes the ARC_BOARD_ANGEL4 and ARC_BOARD_ML509
Kconfig parameters which are no longer used anywhere
in the source code and Makefiles.
This also updates a comment refering to these parameters.
Signed-off-by: Michael Opdenacker <michael.opdenacker@free-electrons.com>
---
arch/arc/plat-arcfpga/Kconfig | 13 -------------
1 file changed, 13 deletions(-)
diff --git a/arch/arc/plat-arcfpga/Kconfig b/arch/arc/plat-arcfpga/Kconfig
index b9f34cf55acf..3f6814aa97ac 100644
--- a/arch/arc/plat-arcfpga/Kconfig
+++ b/arch/arc/plat-arcfpga/Kconfig
@@ -12,23 +12,10 @@ menuconfig ARC_PLAT_FPGA_LEGACY
help
Support for ARC development boards, provided by Synopsys.
These are based on FPGA or ISS. e.g.
- - ARCAngel4
- - ML509
- MetaWare ISS
if ARC_PLAT_FPGA_LEGACY
-config ARC_BOARD_ANGEL4
- bool "ARC Angel4"
- default y
- help
- ARC Angel4 FPGA Ref Platform (Xilinx Virtex Based)
-
-config ARC_BOARD_ML509
- bool "ML509"
- help
- ARC ML509 FPGA Ref Platform (Xilinx Virtex-5 Based)
-
config ISS_SMP_EXTN
bool "ARC SMP Extensions (ISS Models only)"
default n
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ARC: [plat-arcfpga]: remove unused Kconfig params
2014-10-01 9:59 [PATCH] ARC: [plat-arcfpga]: remove unused Kconfig params Michael Opdenacker
@ 2014-10-01 10:12 ` Paul Bolle
2014-10-02 20:02 ` Michael Opdenacker
0 siblings, 1 reply; 3+ messages in thread
From: Paul Bolle @ 2014-10-01 10:12 UTC (permalink / raw)
To: Michael Opdenacker; +Cc: vgupta, richard, gregkh, linux-kernel
On Wed, 2014-10-01 at 11:59 +0200, Michael Opdenacker wrote:
> This removes the ARC_BOARD_ANGEL4 and ARC_BOARD_ML509
> Kconfig parameters which are no longer used anywhere
> in the source code and Makefiles.
>
> This also updates a comment refering to these parameters.
>
> Signed-off-by: Michael Opdenacker <michael.opdenacker@free-electrons.com>
> ---
See commit 774b689502d4 ("ARC: [arcfpga] Get rid of ARC_BOARD_ANGEL4 and
ARC_BOARD_ML509") in linux-next since yesterday.
> arch/arc/plat-arcfpga/Kconfig | 13 -------------
> 1 file changed, 13 deletions(-)
>
> diff --git a/arch/arc/plat-arcfpga/Kconfig b/arch/arc/plat-arcfpga/Kconfig
> index b9f34cf55acf..3f6814aa97ac 100644
> --- a/arch/arc/plat-arcfpga/Kconfig
> +++ b/arch/arc/plat-arcfpga/Kconfig
> @@ -12,23 +12,10 @@ menuconfig ARC_PLAT_FPGA_LEGACY
> help
> Support for ARC development boards, provided by Synopsys.
> These are based on FPGA or ISS. e.g.
> - - ARCAngel4
> - - ML509
> - MetaWare ISS
It doesn't follow from the fact that these Kconfig symbols are unused
that this help text is now incorrect. How did you establish that?
> if ARC_PLAT_FPGA_LEGACY
>
> -config ARC_BOARD_ANGEL4
> - bool "ARC Angel4"
> - default y
> - help
> - ARC Angel4 FPGA Ref Platform (Xilinx Virtex Based)
> -
> -config ARC_BOARD_ML509
> - bool "ML509"
> - help
> - ARC ML509 FPGA Ref Platform (Xilinx Virtex-5 Based)
> -
> config ISS_SMP_EXTN
> bool "ARC SMP Extensions (ISS Models only)"
> default n
Paul Bolle
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ARC: [plat-arcfpga]: remove unused Kconfig params
2014-10-01 10:12 ` Paul Bolle
@ 2014-10-02 20:02 ` Michael Opdenacker
0 siblings, 0 replies; 3+ messages in thread
From: Michael Opdenacker @ 2014-10-02 20:02 UTC (permalink / raw)
To: Paul Bolle; +Cc: vgupta, richard, gregkh, linux-kernel
Hi Paul,
Thank you for reviewing my patch!
On 10/01/2014 12:12 PM, Paul Bolle wrote:
> On Wed, 2014-10-01 at 11:59 +0200, Michael Opdenacker wrote:
>> This removes the ARC_BOARD_ANGEL4 and ARC_BOARD_ML509
>> Kconfig parameters which are no longer used anywhere
>> in the source code and Makefiles.
>>
>> This also updates a comment refering to these parameters.
>>
>> Signed-off-by: Michael Opdenacker <michael.opdenacker@free-electrons.com>
>> ---
> See commit 774b689502d4 ("ARC: [arcfpga] Get rid of ARC_BOARD_ANGEL4 and
> ARC_BOARD_ML509") in linux-next since yesterday.
Great. Happy to drop my patch then!
>
>> arch/arc/plat-arcfpga/Kconfig | 13 -------------
>> 1 file changed, 13 deletions(-)
>>
>> diff --git a/arch/arc/plat-arcfpga/Kconfig b/arch/arc/plat-arcfpga/Kconfig
>> index b9f34cf55acf..3f6814aa97ac 100644
>> --- a/arch/arc/plat-arcfpga/Kconfig
>> +++ b/arch/arc/plat-arcfpga/Kconfig
>> @@ -12,23 +12,10 @@ menuconfig ARC_PLAT_FPGA_LEGACY
>> help
>> Support for ARC development boards, provided by Synopsys.
>> These are based on FPGA or ISS. e.g.
>> - - ARCAngel4
>> - - ML509
>> - MetaWare ISS
> It doesn't follow from the fact that these Kconfig symbols are unused
> that this help text is now incorrect. How did you establish that?
Oops, you're definitely right. Pfooh, starting to make the confusion
between data and metadata... scary.
Cheers,
Michael.
--
Michael Opdenacker, CEO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
+33 484 258 098
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-10-02 20:02 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-10-01 9:59 [PATCH] ARC: [plat-arcfpga]: remove unused Kconfig params Michael Opdenacker
2014-10-01 10:12 ` Paul Bolle
2014-10-02 20:02 ` Michael Opdenacker
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox