* [PATCH v2] networking: fm10k: Fix build failure
@ 2014-10-10 5:19 Pranith Kumar
2014-10-10 5:20 ` David Miller
2014-10-10 5:22 ` Jeff Kirsher
0 siblings, 2 replies; 3+ messages in thread
From: Pranith Kumar @ 2014-10-10 5:19 UTC (permalink / raw)
To: Jeff Kirsher, Jesse Brandeburg, Bruce Allan, Carolyn Wyborny,
Don Skidmore, Greg Rose, Matthew Vick, John Ronciak,
Mitch Williams, Linux NICS, open list:INTEL ETHERNET DR...,
open list:NETWORKING DRIVERS, open list
The latest linus git tip (3.18-rc1) fails with the following build failure. Fix
this by making PTP support explicit for fm10k driver.
rivers/built-in.o: In function `fm10k_ptp_register':
(.text+0x12e760): undefined reference to `ptp_clock_registER'
drivers/built-in.o: In function `fm10k_ptp_unregister':
(.text+0x12e7dc): undefined reference to `ptp_clock_unregister'
Makefile:930: recipe for target 'vmlinux' failed
Signed-off-by: Pranith Kumar <bobby.prani@gmail.com>
---
drivers/net/ethernet/intel/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/intel/Kconfig b/drivers/net/ethernet/intel/Kconfig
index 6a6d5ee..6919adb 100644
--- a/drivers/net/ethernet/intel/Kconfig
+++ b/drivers/net/ethernet/intel/Kconfig
@@ -304,6 +304,7 @@ config FM10K
tristate "Intel(R) FM10000 Ethernet Switch Host Interface Support"
default n
depends on PCI_MSI
+ select PTP_1588_CLOCK
---help---
This driver supports Intel(R) FM10000 Ethernet Switch Host
Interface. For more information on how to identify your adapter,
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] networking: fm10k: Fix build failure
2014-10-10 5:19 [PATCH v2] networking: fm10k: Fix build failure Pranith Kumar
@ 2014-10-10 5:20 ` David Miller
2014-10-10 5:22 ` Jeff Kirsher
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2014-10-10 5:20 UTC (permalink / raw)
To: bobby.prani
Cc: jeffrey.t.kirsher, jesse.brandeburg, bruce.w.allan,
carolyn.wyborny, donald.c.skidmore, gregory.v.rose, matthew.vick,
john.ronciak, mitch.a.williams, linux.nics, e1000-devel, netdev,
linux-kernel
From: Pranith Kumar <bobby.prani@gmail.com>
Date: Fri, 10 Oct 2014 01:19:06 -0400
> The latest linus git tip (3.18-rc1) fails with the following build failure. Fix
> this by making PTP support explicit for fm10k driver.
>
> rivers/built-in.o: In function `fm10k_ptp_register':
> (.text+0x12e760): undefined reference to `ptp_clock_registER'
> drivers/built-in.o: In function `fm10k_ptp_unregister':
> (.text+0x12e7dc): undefined reference to `ptp_clock_unregister'
> Makefile:930: recipe for target 'vmlinux' failed
>
> Signed-off-by: Pranith Kumar <bobby.prani@gmail.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] networking: fm10k: Fix build failure
2014-10-10 5:19 [PATCH v2] networking: fm10k: Fix build failure Pranith Kumar
2014-10-10 5:20 ` David Miller
@ 2014-10-10 5:22 ` Jeff Kirsher
1 sibling, 0 replies; 3+ messages in thread
From: Jeff Kirsher @ 2014-10-10 5:22 UTC (permalink / raw)
To: Pranith Kumar
Cc: Jesse Brandeburg, Bruce Allan, Carolyn Wyborny, Don Skidmore,
Greg Rose, Matthew Vick, John Ronciak, Mitch Williams, Linux NICS,
open list:INTEL ETHERNET DR..., open list:NETWORKING DRIVERS,
open list
[-- Attachment #1: Type: text/plain, Size: 1354 bytes --]
On Fri, 2014-10-10 at 01:19 -0400, Pranith Kumar wrote:
> The latest linus git tip (3.18-rc1) fails with the following build failure. Fix
> this by making PTP support explicit for fm10k driver.
>
> rivers/built-in.o: In function `fm10k_ptp_register':
> (.text+0x12e760): undefined reference to `ptp_clock_registER'
> drivers/built-in.o: In function `fm10k_ptp_unregister':
> (.text+0x12e7dc): undefined reference to `ptp_clock_unregister'
> Makefile:930: recipe for target 'vmlinux' failed
>
> Signed-off-by: Pranith Kumar <bobby.prani@gmail.com>
Acked-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Dave- go ahead and pull this in directly, no need for me to put this
through our internal process.
> ---
> drivers/net/ethernet/intel/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/ethernet/intel/Kconfig b/drivers/net/ethernet/intel/Kconfig
> index 6a6d5ee..6919adb 100644
> --- a/drivers/net/ethernet/intel/Kconfig
> +++ b/drivers/net/ethernet/intel/Kconfig
> @@ -304,6 +304,7 @@ config FM10K
> tristate "Intel(R) FM10000 Ethernet Switch Host Interface Support"
> default n
> depends on PCI_MSI
> + select PTP_1588_CLOCK
> ---help---
> This driver supports Intel(R) FM10000 Ethernet Switch Host
> Interface. For more information on how to identify your adapter,
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-10-10 5:22 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-10-10 5:19 [PATCH v2] networking: fm10k: Fix build failure Pranith Kumar
2014-10-10 5:20 ` David Miller
2014-10-10 5:22 ` Jeff Kirsher
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox