The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Paul Bolle <pebolle@tiscali.nl>
To: Peter Foley <pefoley2@pefoley.com>
Cc: linux-kernel@vger.kernel.org, rdunlap@infradead.org,
	jkosina@suse.cz, luto@amacapital.net, hpa@zytor.com,
	jwboyer@fedoraproject.org, linux-doc@vger.kernel.org
Subject: Re: [PATCH] Documentation: fix vdso_standalone_test_x86 on 32-bit
Date: Mon, 20 Oct 2014 14:23:30 +0200	[thread overview]
Message-ID: <1413807810.17703.6.camel@x41> (raw)
In-Reply-To: <1412797764-11466-1-git-send-email-pefoley2@pefoley.com>

Peter Foley schreef op wo 08-10-2014 om 15:49 [-0400]:
> vdso_standalone_test_x86 needs -lgcc_s to build succesfully on 32bit.
> 
> Signed-off-by: Peter Foley <pefoley2@pefoley.com>
> ---
>  Documentation/vDSO/Makefile | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/Documentation/vDSO/Makefile b/Documentation/vDSO/Makefile
> index 2b99e57..5e5ad9f 100644
> --- a/Documentation/vDSO/Makefile
> +++ b/Documentation/vDSO/Makefile
> @@ -10,3 +10,6 @@ always := $(hostprogs-y)
>  HOSTCFLAGS := -I$(objtree)/usr/include -std=gnu99
>  HOSTCFLAGS_vdso_standalone_test_x86.o := -fno-asynchronous-unwind-tables -fno-stack-protector
>  HOSTLOADLIBES_vdso_standalone_test_x86 := -nostdlib
> +ifeq($(CONFIG_X86_32),y)
> +HOSTLOADLIBES_vdso_standalone_test_x86 += -lgcc_s
> +endif

Applying this patch on top of v3.18-rc1 to get it to build for 32 bit
x86 triggers this build error (when calling "make -s mrproper", which is
done early in the build of a Fedora kernel rpm):
    Documentation/vDSO/Makefile:13: *** missing separator.  Stop.
    make[1]: *** [Documentation/vDSO] Error 2
    make: *** [_clean_Documentation] Error 2

Using 
    ifeq ($(CONFIG_X86_32),y)

fixes that error. And with that space added this patch unbreaks the
build of v3.18-rc1 for 32 bit x86.

Thanks,


Paul Bolle


      parent reply	other threads:[~2014-10-20 12:23 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-08 19:49 [PATCH] Documentation: fix vdso_standalone_test_x86 on 32-bit Peter Foley
2014-10-08 19:54 ` H. Peter Anvin
2014-10-08 22:52   ` Peter Foley
2014-10-20 12:23 ` Paul Bolle [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1413807810.17703.6.camel@x41 \
    --to=pebolle@tiscali.nl \
    --cc=hpa@zytor.com \
    --cc=jkosina@suse.cz \
    --cc=jwboyer@fedoraproject.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luto@amacapital.net \
    --cc=pefoley2@pefoley.com \
    --cc=rdunlap@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox