* [PATCH] Documentation: fix vdso_standalone_test_x86 on 32-bit
@ 2014-10-08 19:49 Peter Foley
2014-10-08 19:54 ` H. Peter Anvin
2014-10-20 12:23 ` Paul Bolle
0 siblings, 2 replies; 4+ messages in thread
From: Peter Foley @ 2014-10-08 19:49 UTC (permalink / raw)
To: linux-kernel; +Cc: rdunlap, jkosina, luto, hpa, jwboyer, linux-doc, Peter Foley
vdso_standalone_test_x86 needs -lgcc_s to build succesfully on 32bit.
Signed-off-by: Peter Foley <pefoley2@pefoley.com>
---
Documentation/vDSO/Makefile | 3 +++
1 file changed, 3 insertions(+)
diff --git a/Documentation/vDSO/Makefile b/Documentation/vDSO/Makefile
index 2b99e57..5e5ad9f 100644
--- a/Documentation/vDSO/Makefile
+++ b/Documentation/vDSO/Makefile
@@ -10,3 +10,6 @@ always := $(hostprogs-y)
HOSTCFLAGS := -I$(objtree)/usr/include -std=gnu99
HOSTCFLAGS_vdso_standalone_test_x86.o := -fno-asynchronous-unwind-tables -fno-stack-protector
HOSTLOADLIBES_vdso_standalone_test_x86 := -nostdlib
+ifeq($(CONFIG_X86_32),y)
+HOSTLOADLIBES_vdso_standalone_test_x86 += -lgcc_s
+endif
--
2.1.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] Documentation: fix vdso_standalone_test_x86 on 32-bit
2014-10-08 19:49 [PATCH] Documentation: fix vdso_standalone_test_x86 on 32-bit Peter Foley
@ 2014-10-08 19:54 ` H. Peter Anvin
2014-10-08 22:52 ` Peter Foley
2014-10-20 12:23 ` Paul Bolle
1 sibling, 1 reply; 4+ messages in thread
From: H. Peter Anvin @ 2014-10-08 19:54 UTC (permalink / raw)
To: Peter Foley, linux-kernel; +Cc: rdunlap, jkosina, luto, jwboyer, linux-doc
This still has the cross-build problems, no?
On October 8, 2014 12:49:24 PM PDT, Peter Foley <pefoley2@pefoley.com> wrote:
>vdso_standalone_test_x86 needs -lgcc_s to build succesfully on 32bit.
>
>Signed-off-by: Peter Foley <pefoley2@pefoley.com>
>---
> Documentation/vDSO/Makefile | 3 +++
> 1 file changed, 3 insertions(+)
>
>diff --git a/Documentation/vDSO/Makefile b/Documentation/vDSO/Makefile
>index 2b99e57..5e5ad9f 100644
>--- a/Documentation/vDSO/Makefile
>+++ b/Documentation/vDSO/Makefile
>@@ -10,3 +10,6 @@ always := $(hostprogs-y)
> HOSTCFLAGS := -I$(objtree)/usr/include -std=gnu99
>HOSTCFLAGS_vdso_standalone_test_x86.o :=
>-fno-asynchronous-unwind-tables -fno-stack-protector
> HOSTLOADLIBES_vdso_standalone_test_x86 := -nostdlib
>+ifeq($(CONFIG_X86_32),y)
>+HOSTLOADLIBES_vdso_standalone_test_x86 += -lgcc_s
>+endif
--
Sent from my mobile phone. Please pardon brevity and lack of formatting.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Documentation: fix vdso_standalone_test_x86 on 32-bit
2014-10-08 19:54 ` H. Peter Anvin
@ 2014-10-08 22:52 ` Peter Foley
0 siblings, 0 replies; 4+ messages in thread
From: Peter Foley @ 2014-10-08 22:52 UTC (permalink / raw)
To: H. Peter Anvin
Cc: LKML, Randy Dunlap, jkosina, luto, jwboyer,
linux-doc@vger.kernel.org
On Wed, Oct 8, 2014 at 3:54 PM, H. Peter Anvin <hpa@zytor.com> wrote:
> This still has the cross-build problems, no?
>
Yes, but that issue is more general to CONFIG_BUILD_DOCSRC.
This is just a build failure on x86-32.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Documentation: fix vdso_standalone_test_x86 on 32-bit
2014-10-08 19:49 [PATCH] Documentation: fix vdso_standalone_test_x86 on 32-bit Peter Foley
2014-10-08 19:54 ` H. Peter Anvin
@ 2014-10-20 12:23 ` Paul Bolle
1 sibling, 0 replies; 4+ messages in thread
From: Paul Bolle @ 2014-10-20 12:23 UTC (permalink / raw)
To: Peter Foley; +Cc: linux-kernel, rdunlap, jkosina, luto, hpa, jwboyer, linux-doc
Peter Foley schreef op wo 08-10-2014 om 15:49 [-0400]:
> vdso_standalone_test_x86 needs -lgcc_s to build succesfully on 32bit.
>
> Signed-off-by: Peter Foley <pefoley2@pefoley.com>
> ---
> Documentation/vDSO/Makefile | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/Documentation/vDSO/Makefile b/Documentation/vDSO/Makefile
> index 2b99e57..5e5ad9f 100644
> --- a/Documentation/vDSO/Makefile
> +++ b/Documentation/vDSO/Makefile
> @@ -10,3 +10,6 @@ always := $(hostprogs-y)
> HOSTCFLAGS := -I$(objtree)/usr/include -std=gnu99
> HOSTCFLAGS_vdso_standalone_test_x86.o := -fno-asynchronous-unwind-tables -fno-stack-protector
> HOSTLOADLIBES_vdso_standalone_test_x86 := -nostdlib
> +ifeq($(CONFIG_X86_32),y)
> +HOSTLOADLIBES_vdso_standalone_test_x86 += -lgcc_s
> +endif
Applying this patch on top of v3.18-rc1 to get it to build for 32 bit
x86 triggers this build error (when calling "make -s mrproper", which is
done early in the build of a Fedora kernel rpm):
Documentation/vDSO/Makefile:13: *** missing separator. Stop.
make[1]: *** [Documentation/vDSO] Error 2
make: *** [_clean_Documentation] Error 2
Using
ifeq ($(CONFIG_X86_32),y)
fixes that error. And with that space added this patch unbreaks the
build of v3.18-rc1 for 32 bit x86.
Thanks,
Paul Bolle
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-10-20 12:23 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-10-08 19:49 [PATCH] Documentation: fix vdso_standalone_test_x86 on 32-bit Peter Foley
2014-10-08 19:54 ` H. Peter Anvin
2014-10-08 22:52 ` Peter Foley
2014-10-20 12:23 ` Paul Bolle
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox