From: Geoff Levand <geoff@infradead.org>
To: JBottomley@parallels.com
Cc: Michael Ellerman <mpe@ellerman.id.au>,
linux-kernel@vger.kernel.org, trivial@kernel.org
Subject: Re: [PATCH] [SCSI] ps3rom: fix error return code
Date: Wed, 05 Nov 2014 09:54:13 -0800 [thread overview]
Message-ID: <1415210053.12884.11.camel@smoke> (raw)
In-Reply-To: <1415182270-25237-1-git-send-email-mpe@ellerman.id.au>
On Wed, 2014-11-05 at 21:11 +1100, Michael Ellerman wrote:
> From: Julia Lawall <Julia.Lawall@lip6.fr>
>
> Set the return variable to an error code as done elsewhere in the function.
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
> Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
> ---
> drivers/scsi/ps3rom.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/scsi/ps3rom.c b/drivers/scsi/ps3rom.c
> index ef23fabe3924..619caf1acc9c 100644
> --- a/drivers/scsi/ps3rom.c
> +++ b/drivers/scsi/ps3rom.c
> @@ -387,6 +387,7 @@ static int ps3rom_probe(struct ps3_system_bus_device *_dev)
> if (!host) {
> dev_err(&dev->sbd.core, "%s:%u: scsi_host_alloc failed\n",
> __func__, __LINE__);
> + error = -ENOMEM;
> goto fail_teardown;
> }
>
Looks OK. James, please apply.
Acked-By: Geoff Levand <geoff@infradead.org>
prev parent reply other threads:[~2014-11-05 17:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-05 10:11 [PATCH] [SCSI] ps3rom: fix error return code Michael Ellerman
2014-11-05 17:54 ` Geoff Levand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1415210053.12884.11.camel@smoke \
--to=geoff@infradead.org \
--cc=JBottomley@parallels.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mpe@ellerman.id.au \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox