* [PATCH] [SCSI] ps3rom: fix error return code
@ 2014-11-05 10:11 Michael Ellerman
2014-11-05 17:54 ` Geoff Levand
0 siblings, 1 reply; 2+ messages in thread
From: Michael Ellerman @ 2014-11-05 10:11 UTC (permalink / raw)
To: geoff, JBottomley; +Cc: linux-kernel, trivial
From: Julia Lawall <Julia.Lawall@lip6.fr>
Set the return variable to an error code as done elsewhere in the function.
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
---
drivers/scsi/ps3rom.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/scsi/ps3rom.c b/drivers/scsi/ps3rom.c
index ef23fabe3924..619caf1acc9c 100644
--- a/drivers/scsi/ps3rom.c
+++ b/drivers/scsi/ps3rom.c
@@ -387,6 +387,7 @@ static int ps3rom_probe(struct ps3_system_bus_device *_dev)
if (!host) {
dev_err(&dev->sbd.core, "%s:%u: scsi_host_alloc failed\n",
__func__, __LINE__);
+ error = -ENOMEM;
goto fail_teardown;
}
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] [SCSI] ps3rom: fix error return code
2014-11-05 10:11 [PATCH] [SCSI] ps3rom: fix error return code Michael Ellerman
@ 2014-11-05 17:54 ` Geoff Levand
0 siblings, 0 replies; 2+ messages in thread
From: Geoff Levand @ 2014-11-05 17:54 UTC (permalink / raw)
To: JBottomley; +Cc: Michael Ellerman, linux-kernel, trivial
On Wed, 2014-11-05 at 21:11 +1100, Michael Ellerman wrote:
> From: Julia Lawall <Julia.Lawall@lip6.fr>
>
> Set the return variable to an error code as done elsewhere in the function.
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
> Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
> ---
> drivers/scsi/ps3rom.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/scsi/ps3rom.c b/drivers/scsi/ps3rom.c
> index ef23fabe3924..619caf1acc9c 100644
> --- a/drivers/scsi/ps3rom.c
> +++ b/drivers/scsi/ps3rom.c
> @@ -387,6 +387,7 @@ static int ps3rom_probe(struct ps3_system_bus_device *_dev)
> if (!host) {
> dev_err(&dev->sbd.core, "%s:%u: scsi_host_alloc failed\n",
> __func__, __LINE__);
> + error = -ENOMEM;
> goto fail_teardown;
> }
>
Looks OK. James, please apply.
Acked-By: Geoff Levand <geoff@infradead.org>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-11-05 17:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-11-05 10:11 [PATCH] [SCSI] ps3rom: fix error return code Michael Ellerman
2014-11-05 17:54 ` Geoff Levand
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox