* [PATCH] cgroups: Documentation: fix wrong cgroupfs paths
@ 2014-11-24 16:39 SeongJae Park
2014-11-24 17:45 ` Jonathan Corbet
0 siblings, 1 reply; 3+ messages in thread
From: SeongJae Park @ 2014-11-24 16:39 UTC (permalink / raw)
To: tj; +Cc: lizefan, corbet, cgroups, linux-doc, linux-kernel, SeongJae Park
Few paths used as example to describe cgroupfs usage have been wrong
from f6e07d38078e ("Documentation: update cgroupfs mount point") by
mistake. This patch fix those trivial wrong paths.
Signed-off-by: SeongJae Park <sj38.park@gmail.com>
---
Documentation/cgroups/cgroups.txt | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/Documentation/cgroups/cgroups.txt b/Documentation/cgroups/cgroups.txt
index 10c949b..f935fac 100644
--- a/Documentation/cgroups/cgroups.txt
+++ b/Documentation/cgroups/cgroups.txt
@@ -312,10 +312,10 @@ the "cpuset" cgroup subsystem, the steps are something like:
2) mkdir /sys/fs/cgroup/cpuset
3) mount -t cgroup -ocpuset cpuset /sys/fs/cgroup/cpuset
4) Create the new cgroup by doing mkdir's and write's (or echo's) in
- the /sys/fs/cgroup virtual file system.
+ the /sys/fs/cgroup/cpuset virtual file system.
5) Start a task that will be the "founding father" of the new job.
6) Attach that task to the new cgroup by writing its PID to the
- /sys/fs/cgroup/cpuset/tasks file for that cgroup.
+ /sys/fs/cgroup/cpuset tasks file for that cgroup.
7) fork, exec or clone the job tasks from this founding father task.
For example, the following sequence of commands will setup a cgroup
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] cgroups: Documentation: fix wrong cgroupfs paths
2014-11-24 16:39 [PATCH] cgroups: Documentation: fix wrong cgroupfs paths SeongJae Park
@ 2014-11-24 17:45 ` Jonathan Corbet
2014-11-24 18:41 ` SeongJae Park
0 siblings, 1 reply; 3+ messages in thread
From: Jonathan Corbet @ 2014-11-24 17:45 UTC (permalink / raw)
To: SeongJae Park; +Cc: tj, lizefan, cgroups, linux-doc, linux-kernel
On Tue, 25 Nov 2014 01:39:19 +0900
SeongJae Park <sj38.park@gmail.com> wrote:
> 6) Attach that task to the new cgroup by writing its PID to the
> - /sys/fs/cgroup/cpuset/tasks file for that cgroup.
> + /sys/fs/cgroup/cpuset tasks file for that cgroup.
That one looks like it was correct before the change...? What am I
missing here?
Thanks,
jon
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] cgroups: Documentation: fix wrong cgroupfs paths
2014-11-24 17:45 ` Jonathan Corbet
@ 2014-11-24 18:41 ` SeongJae Park
0 siblings, 0 replies; 3+ messages in thread
From: SeongJae Park @ 2014-11-24 18:41 UTC (permalink / raw)
To: Jonathan Corbet
Cc: tj, lizefan, cgroups, linux-doc, linux-kernel@vger.kernel.org
On Tue, Nov 25, 2014 at 2:45 AM, Jonathan Corbet <corbet@lwn.net> wrote:
> On Tue, 25 Nov 2014 01:39:19 +0900
> SeongJae Park <sj38.park@gmail.com> wrote:
>
>> 6) Attach that task to the new cgroup by writing its PID to the
>> - /sys/fs/cgroup/cpuset/tasks file for that cgroup.
>> + /sys/fs/cgroup/cpuset tasks file for that cgroup.
>
> That one looks like it was correct before the change...? What am I
> missing here?
It should represents /sys/fs/cgroup/cpuset/<*new cgroup name*>/tasks,
not /sys/fs/cgroup/cpuset/tasks.
If there are better suggestions or anything I am missing, please let me
know.
Thanks,
SeongJae Park
>
> Thanks,
>
> jon
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-11-24 18:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-11-24 16:39 [PATCH] cgroups: Documentation: fix wrong cgroupfs paths SeongJae Park
2014-11-24 17:45 ` Jonathan Corbet
2014-11-24 18:41 ` SeongJae Park
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox