From: Joe Perches <joe@perches.com>
To: Tolga Ceylan <tolga.ceylan@gmail.com>
Cc: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Sanjeev Sharma" <sanjeev_sharma@mentor.com>,
"Mohammad Jamal" <md.jamalmohiuddin@gmail.com>,
"Loïc Pellegrino" <oort10@gmail.com>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] Staging: rtl8192u: Coding Style Improvements
Date: Sun, 08 Feb 2015 01:54:57 -0800 [thread overview]
Message-ID: <1423389297.2933.13.camel@perches.com> (raw)
In-Reply-To: <1423388966-8204-1-git-send-email-tolga.ceylan@gmail.com>
On Sun, 2015-02-08 at 01:49 -0800, Tolga Ceylan wrote:
> Lines over 80 were corrected
[]
> diff --git a/drivers/staging/rtl8192u/r8190_rtl8256.c b/drivers/staging/rtl8192u/r8190_rtl8256.c
[]
> @@ -37,43 +37,71 @@ void PHY_SetRF8256Bandwidth(struct net_device *dev, HT_CHANNEL_WIDTH Bandwidth)
[]
> + /* 8256 D-cut, E-cut, xiong: consider it later! */
> + if (priv->card_8192_version == VERSION_819xU_A
> + || priv->card_8192_version == VERSION_819xU_B) {
This is more commonly written:
if (priv->card_8192_version == VERSION_819xU_A ||
priv->card_8192_version == VERSION_819xU_B) {
next prev parent reply other threads:[~2015-02-08 9:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-08 9:49 [PATCH 1/1] Staging: rtl8192u: Coding Style Improvements Tolga Ceylan
2015-02-08 9:54 ` Joe Perches [this message]
2015-02-09 4:45 ` Tolga Ceylan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1423389297.2933.13.camel@perches.com \
--to=joe@perches.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=md.jamalmohiuddin@gmail.com \
--cc=oort10@gmail.com \
--cc=sanjeev_sharma@mentor.com \
--cc=tolga.ceylan@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox