public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: riel@redhat.com
To: paulmck@linux.vnet.ibm.com
Cc: linux-kernel@vger.kernel.org, catalin.marinas@arm.com,
	will.deacon@arm.com, fweisbec@gmail.com, kvm@vger.kernel.org,
	mtosatti@redhat.com, borntraeger@de.ibm.com, mingo@kernel.org,
	oleg@redhat.com, lcapitulino@redhat.com, pbonzini@redhat.com,
	Rik van Riel <riel@redhat.com>
Subject: [PATCH 3/6] rcu,nohz: run vtime_user_enter/exit only when state == IN_USER
Date: Mon,  9 Feb 2015 11:04:41 -0500	[thread overview]
Message-ID: <1423497884-21615-4-git-send-email-riel@redhat.com> (raw)
In-Reply-To: <1423497884-21615-1-git-send-email-riel@redhat.com>

From: Rik van Riel <riel@redhat.com>

Only run vtime_user_enter, vtime_user_exit, and the user enter & exit
trace points when we are entering or exiting user state, respectively.

The RCU code only distinguishes between "idle" and "not idle or kernel".
There should be no need to add an additional (unused) state there.

Signed-off-by: Rik van Riel <riel@redhat.com>
---
 kernel/context_tracking.c | 12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)

diff --git a/kernel/context_tracking.c b/kernel/context_tracking.c
index e031e8c0fb91..2d94147c07b2 100644
--- a/kernel/context_tracking.c
+++ b/kernel/context_tracking.c
@@ -77,7 +77,6 @@ void context_tracking_enter(enum ctx_state state)
 	local_irq_save(flags);
 	if ( __this_cpu_read(context_tracking.state) != state) {
 		if (__this_cpu_read(context_tracking.active)) {
-			trace_user_enter(0);
 			/*
 			 * At this stage, only low level arch entry code remains and
 			 * then we'll run in userspace. We can assume there won't be
@@ -85,7 +84,10 @@ void context_tracking_enter(enum ctx_state state)
 			 * user_exit() or rcu_irq_enter(). Let's remove RCU's dependency
 			 * on the tick.
 			 */
-			vtime_user_enter(current);
+			if (state == IN_USER) {
+				trace_user_enter(0);
+				vtime_user_enter(current);
+			}
 			rcu_user_enter();
 		}
 		/*
@@ -137,8 +139,10 @@ void context_tracking_exit(enum ctx_state state)
 			 * RCU core about that (ie: we may need the tick again).
 			 */
 			rcu_user_exit();
-			vtime_user_exit(current);
-			trace_user_exit(0);
+			if (state == IN_USER) {
+				vtime_user_exit(current);
+				trace_user_exit(0);
+			}
 		}
 		__this_cpu_write(context_tracking.state, IN_KERNEL);
 	}
-- 
1.9.3


  parent reply	other threads:[~2015-02-09 16:05 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-09 16:04 [PATCH -v3 0/6] rcu,nohz,kvm: use RCU extended quiescent state when running KVM guest riel
2015-02-09 16:04 ` [PATCH 1/6] rcu,nohz: add state parameter to context_tracking_user_enter/exit riel
2015-02-09 16:04 ` [PATCH 2/6] rcu,nohz: rename context_tracking_enter & _exit riel
2015-02-09 16:04 ` riel [this message]
2015-02-09 16:04 ` [PATCH 4/6] nohz,kvm: export context_tracking_user_enter/exit riel
2015-02-09 17:05   ` Paolo Bonzini
2015-02-09 20:02     ` Rik van Riel
2015-02-09 16:04 ` [PATCH 5/6] kvm,rcu,nohz: use RCU extended quiescent state when running KVM guest riel
2015-02-09 16:04 ` [PATCH 6/6] nohz: add stub context_tracking_is_enabled riel
2015-02-09 17:07   ` Paolo Bonzini
2015-02-10  1:15 ` [PATCH -v3 0/6] rcu,nohz,kvm: use RCU extended quiescent state when running KVM guest Will Deacon
2015-02-10  1:22   ` Rik van Riel
2015-02-10  1:44     ` Frederic Weisbecker
2015-02-10  3:01       ` Paul E. McKenney
2015-02-10  3:03         ` Rik van Riel
2015-02-10  3:13           ` Paul E. McKenney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1423497884-21615-4-git-send-email-riel@redhat.com \
    --to=riel@redhat.com \
    --cc=borntraeger@de.ibm.com \
    --cc=catalin.marinas@arm.com \
    --cc=fweisbec@gmail.com \
    --cc=kvm@vger.kernel.org \
    --cc=lcapitulino@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=mtosatti@redhat.com \
    --cc=oleg@redhat.com \
    --cc=paulmck@linux.vnet.ibm.com \
    --cc=pbonzini@redhat.com \
    --cc=will.deacon@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox