From: riel@redhat.com
To: paulmck@linux.vnet.ibm.com
Cc: linux-kernel@vger.kernel.org, catalin.marinas@arm.com,
will.deacon@arm.com, fweisbec@gmail.com, kvm@vger.kernel.org,
mtosatti@redhat.com, borntraeger@de.ibm.com, mingo@kernel.org,
oleg@redhat.com, lcapitulino@redhat.com, pbonzini@redhat.com,
Rik van Riel <riel@redhat.com>
Subject: [PATCH 5/6] kvm,rcu,nohz: use RCU extended quiescent state when running KVM guest
Date: Mon, 9 Feb 2015 11:04:43 -0500 [thread overview]
Message-ID: <1423497884-21615-6-git-send-email-riel@redhat.com> (raw)
In-Reply-To: <1423497884-21615-1-git-send-email-riel@redhat.com>
From: Rik van Riel <riel@redhat.com>
The host kernel is not doing anything while the CPU is executing
a KVM guest VCPU, so it can be marked as being in an extended
quiescent state, identical to that used when running user space
code.
The only exception to that rule is when the host handles an
interrupt, which is already handled by the irq code, which
calls rcu_irq_enter and rcu_irq_exit.
The guest_enter and guest_exit functions already switch vtime
accounting independent of context tracking, so leave those calls
where they are, instead of moving them into the context tracking
code.
Signed-off-by: Rik van Riel <riel@redhat.com>
---
include/linux/context_tracking.h | 8 +++++++-
include/linux/context_tracking_state.h | 1 +
include/linux/kvm_host.h | 3 ++-
3 files changed, 10 insertions(+), 2 deletions(-)
diff --git a/include/linux/context_tracking.h b/include/linux/context_tracking.h
index 29d7fecb365a..c70d7e760061 100644
--- a/include/linux/context_tracking.h
+++ b/include/linux/context_tracking.h
@@ -43,7 +43,7 @@ static inline enum ctx_state exception_enter(void)
static inline void exception_exit(enum ctx_state prev_ctx)
{
if (context_tracking_is_enabled()) {
- if (prev_ctx == IN_USER)
+ if (prev_ctx != IN_KERNEL)
context_tracking_enter(prev_ctx);
}
}
@@ -74,6 +74,9 @@ static inline void context_tracking_init(void) { }
#ifdef CONFIG_VIRT_CPU_ACCOUNTING_GEN
static inline void guest_enter(void)
{
+ if (context_tracking_is_enabled())
+ context_tracking_enter(IN_GUEST);
+
if (vtime_accounting_enabled())
vtime_guest_enter(current);
else
@@ -86,6 +89,9 @@ static inline void guest_exit(void)
vtime_guest_exit(current);
else
current->flags &= ~PF_VCPU;
+
+ if (context_tracking_is_enabled())
+ context_tracking_exit(IN_GUEST);
}
#else
diff --git a/include/linux/context_tracking_state.h b/include/linux/context_tracking_state.h
index 97a81225d037..f3ef027af749 100644
--- a/include/linux/context_tracking_state.h
+++ b/include/linux/context_tracking_state.h
@@ -15,6 +15,7 @@ struct context_tracking {
enum ctx_state {
IN_KERNEL = 0,
IN_USER,
+ IN_GUEST,
} state;
};
diff --git a/include/linux/kvm_host.h b/include/linux/kvm_host.h
index 26f106022c88..c7828a6a9614 100644
--- a/include/linux/kvm_host.h
+++ b/include/linux/kvm_host.h
@@ -772,7 +772,8 @@ static inline void kvm_guest_enter(void)
* one time slice). Lets treat guest mode as quiescent state, just like
* we do with user-mode execution.
*/
- rcu_virt_note_context_switch(smp_processor_id());
+ if (!context_tracking_cpu_is_enabled())
+ rcu_virt_note_context_switch(smp_processor_id());
}
static inline void kvm_guest_exit(void)
--
1.9.3
next prev parent reply other threads:[~2015-02-09 16:07 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-09 16:04 [PATCH -v3 0/6] rcu,nohz,kvm: use RCU extended quiescent state when running KVM guest riel
2015-02-09 16:04 ` [PATCH 1/6] rcu,nohz: add state parameter to context_tracking_user_enter/exit riel
2015-02-09 16:04 ` [PATCH 2/6] rcu,nohz: rename context_tracking_enter & _exit riel
2015-02-09 16:04 ` [PATCH 3/6] rcu,nohz: run vtime_user_enter/exit only when state == IN_USER riel
2015-02-09 16:04 ` [PATCH 4/6] nohz,kvm: export context_tracking_user_enter/exit riel
2015-02-09 17:05 ` Paolo Bonzini
2015-02-09 20:02 ` Rik van Riel
2015-02-09 16:04 ` riel [this message]
2015-02-09 16:04 ` [PATCH 6/6] nohz: add stub context_tracking_is_enabled riel
2015-02-09 17:07 ` Paolo Bonzini
2015-02-10 1:15 ` [PATCH -v3 0/6] rcu,nohz,kvm: use RCU extended quiescent state when running KVM guest Will Deacon
2015-02-10 1:22 ` Rik van Riel
2015-02-10 1:44 ` Frederic Weisbecker
2015-02-10 3:01 ` Paul E. McKenney
2015-02-10 3:03 ` Rik van Riel
2015-02-10 3:13 ` Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1423497884-21615-6-git-send-email-riel@redhat.com \
--to=riel@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=catalin.marinas@arm.com \
--cc=fweisbec@gmail.com \
--cc=kvm@vger.kernel.org \
--cc=lcapitulino@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=mtosatti@redhat.com \
--cc=oleg@redhat.com \
--cc=paulmck@linux.vnet.ibm.com \
--cc=pbonzini@redhat.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox