public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Joe Perches <joe@perches.com>
To: Tom Van Braeckel <tomvanbraeckel@gmail.com>
Cc: apw@canonical.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] checkpatch: support more uppercase $logFunctions
Date: Thu, 19 Mar 2015 02:13:07 -0700	[thread overview]
Message-ID: <1426756387.21142.1.camel@perches.com> (raw)
In-Reply-To: <1426753601-4109-1-git-send-email-tomvanbraeckel@gmail.com>

On Thu, 2015-03-19 at 09:26 +0100, Tom Van Braeckel wrote:
> Add support for uppercase logging function names (so that they may
> exceed 80 cols) and regroup the matched expressions more logically.
> 
> Previously, WARN, WARN_RATELIMIT, WARN_ONCE were already supported but
> many other uppercase logging functions were not and this caused
> unfixable checkpatch warnings (an example: drivers/bluetooth/btusb.c)

I think BT_DBG is a poor macro as it's just

#define BT_DBG(fmt, ...) pr_debug(fmt "\n", ##__VA_ARGS__)

and I'd rather see a treewide sed for that to pr_debug



  reply	other threads:[~2015-03-19  9:13 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-19  6:21 [PATCH] checkpatch: support more uppercase $logFunctions Tom Van Braeckel
2015-03-19  8:26 ` [PATCH v2] " Tom Van Braeckel
2015-03-19  9:13   ` Joe Perches [this message]
2015-03-19  9:57     ` Tom Van Braeckel
2015-03-19 15:02       ` Joe Perches

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1426756387.21142.1.camel@perches.com \
    --to=joe@perches.com \
    --cc=apw@canonical.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tomvanbraeckel@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox