public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Paul Bolle <pebolle@tiscali.nl>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Tom Zanussi <tom.zanussi@linux.intel.com>,
	masami.hiramatsu.pt@hitachi.com, namhyung@kernel.org,
	andi@firstfloor.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 5/7] tracing: Add 'hist' event trigger command
Date: Mon, 06 Apr 2015 18:19:19 +0200	[thread overview]
Message-ID: <1428337159.634.132.camel@x220> (raw)
In-Reply-To: <20150406115012.179e3fa6@gandalf.local.home>

On Mon, 2015-04-06 at 11:50 -0400, Steven Rostedt wrote:
> On Sat, 04 Apr 2015 17:14:56 +0200
> Paul Bolle <pebolle@tiscali.nl> wrote: 
> > > --- a/kernel/trace/Makefile
> > > +++ b/kernel/trace/Makefile
> > 
> > > +obj-$(CONFIG_HIST_TRIGGERS) += trace_events_hist.o
> > 
> > To make sure I'm parsing this Makefile correctly: trace_events_hist.o
> > will never be part of a module, right?
> 
> You don't need to be part of a module to need module.h. You may just
> need module info.

I understand.

But the main reason I added that remark was that recently I ran into a
few patches where I made annoying mistakes in parsing changes to
Makefiles. Doing so I wasted my own and other peoples time. So I decided
to be rather verbose when Makefiles are involved. Just so that people
can:
- mock me for not getting basic stuff right;
- stop paying attention to the rest of my remarks, because chances are I
didn't understand the patch in question correctly.

Thanks,


Paul Bolle


  reply	other threads:[~2015-04-06 16:19 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-03 15:51 [PATCH v3 0/7] tracing: 'hist' triggers Tom Zanussi
2015-04-03 15:51 ` [PATCH v3 1/7] tracing: Make ftrace_event_field checking functions available Tom Zanussi
2015-04-03 15:51 ` [PATCH v3 2/7] tracing: Add event record param to trigger_ops.func() Tom Zanussi
2015-04-03 15:51 ` [PATCH v3 3/7] tracing: Add get_syscall_name() Tom Zanussi
2015-04-03 15:51 ` [PATCH v3 4/7] tracing: Add a per-event-trigger 'paused' field Tom Zanussi
2015-04-03 15:51 ` [PATCH v3 5/7] tracing: Add 'hist' event trigger command Tom Zanussi
2015-04-04 15:14   ` Paul Bolle
2015-04-04 20:09     ` Tom Zanussi
2015-04-04 20:56       ` Paul Bolle
2015-04-04 21:06         ` Tom Zanussi
2015-04-06 15:55       ` Steven Rostedt
2015-04-06 15:50     ` Steven Rostedt
2015-04-06 16:19       ` Paul Bolle [this message]
2015-04-06 16:25         ` Steven Rostedt
2015-04-06 18:07           ` Paul Bolle
2015-04-04 15:36   ` Alexei Starovoitov
2015-04-04 20:25     ` Tom Zanussi
2015-04-03 15:51 ` [PATCH v3 6/7] tracing: Add enable_hist/disable_hist triggers Tom Zanussi
2015-04-03 15:51 ` [PATCH v3 7/7] tracing: Add 'hist' trigger Documentation Tom Zanussi
2015-04-13 21:18 ` [PATCH v3 0/7] tracing: 'hist' triggers Steven Rostedt
2015-04-13 21:49   ` Tom Zanussi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1428337159.634.132.camel@x220 \
    --to=pebolle@tiscali.nl \
    --cc=andi@firstfloor.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=masami.hiramatsu.pt@hitachi.com \
    --cc=namhyung@kernel.org \
    --cc=rostedt@goodmis.org \
    --cc=tom.zanussi@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox