From: Paul Bolle <pebolle@tiscali.nl>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Tom Zanussi <tom.zanussi@linux.intel.com>,
masami.hiramatsu.pt@hitachi.com, namhyung@kernel.org,
andi@firstfloor.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 5/7] tracing: Add 'hist' event trigger command
Date: Mon, 06 Apr 2015 20:07:40 +0200 [thread overview]
Message-ID: <1428343660.634.146.camel@x220> (raw)
In-Reply-To: <20150406122551.6e9ab8bc@gandalf.local.home>
On Mon, 2015-04-06 at 12:25 -0400, Steven Rostedt wrote:
> On Mon, 06 Apr 2015 18:19:19 +0200
> Paul Bolle <pebolle@tiscali.nl> wrote:
> I hope you don't think I was mocking you. I wasn't.
No, I didn't think you were.
> The only issue I can think of that including an unneeded header file
> does is to make the compile slightly longer. It's not a major need to
> do, but it may be done.
This entire conversation was triggered by <linux/module.h>. It has
turned into a bit of a red flag for me.
That is, if I see a patch adding an include of that header while the
code it adds is built-in only, I have a reason to stare at that patch
just a little bit longer. Because there's a chance that the code is
meant to be modular instead of built-in only or that it contains a few
things that are irrelevant for built-in code.
It just happened that things turned out to be rather complicated when I
stared at Tom's patch just a little bit longer.
Thanks,
Paul Bolle
next prev parent reply other threads:[~2015-04-06 18:07 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-03 15:51 [PATCH v3 0/7] tracing: 'hist' triggers Tom Zanussi
2015-04-03 15:51 ` [PATCH v3 1/7] tracing: Make ftrace_event_field checking functions available Tom Zanussi
2015-04-03 15:51 ` [PATCH v3 2/7] tracing: Add event record param to trigger_ops.func() Tom Zanussi
2015-04-03 15:51 ` [PATCH v3 3/7] tracing: Add get_syscall_name() Tom Zanussi
2015-04-03 15:51 ` [PATCH v3 4/7] tracing: Add a per-event-trigger 'paused' field Tom Zanussi
2015-04-03 15:51 ` [PATCH v3 5/7] tracing: Add 'hist' event trigger command Tom Zanussi
2015-04-04 15:14 ` Paul Bolle
2015-04-04 20:09 ` Tom Zanussi
2015-04-04 20:56 ` Paul Bolle
2015-04-04 21:06 ` Tom Zanussi
2015-04-06 15:55 ` Steven Rostedt
2015-04-06 15:50 ` Steven Rostedt
2015-04-06 16:19 ` Paul Bolle
2015-04-06 16:25 ` Steven Rostedt
2015-04-06 18:07 ` Paul Bolle [this message]
2015-04-04 15:36 ` Alexei Starovoitov
2015-04-04 20:25 ` Tom Zanussi
2015-04-03 15:51 ` [PATCH v3 6/7] tracing: Add enable_hist/disable_hist triggers Tom Zanussi
2015-04-03 15:51 ` [PATCH v3 7/7] tracing: Add 'hist' trigger Documentation Tom Zanussi
2015-04-13 21:18 ` [PATCH v3 0/7] tracing: 'hist' triggers Steven Rostedt
2015-04-13 21:49 ` Tom Zanussi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1428343660.634.146.camel@x220 \
--to=pebolle@tiscali.nl \
--cc=andi@firstfloor.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masami.hiramatsu.pt@hitachi.com \
--cc=namhyung@kernel.org \
--cc=rostedt@goodmis.org \
--cc=tom.zanussi@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox