From: Paul Bolle <pebolle@tiscali.nl>
To: Ramakrishna Pallala <ramakrishna.pallala@intel.com>
Cc: linux-kernel@vger.kernel.org, Sebastian Reichel <sre@kernel.org>,
Lee Jones <lee.jones@linaro.org>,
Samuel Ortiz <sameo@linux.intel.com>,
Jacob Pan <jacob.jun.pan@linux.intel.com>
Subject: Re: [RFC PATCH] power: axp288_charger: axp288 charger driver
Date: Sat, 25 Apr 2015 11:09:17 +0200 [thread overview]
Message-ID: <1429952957.2927.95.camel@x220> (raw)
In-Reply-To: <1429895192-11204-1-git-send-email-ramakrishna.pallala@intel.com>
Just a nit: a license mismatch.
On Fri, 2015-04-24 at 22:36 +0530, Ramakrishna Pallala wrote:
> diff --git a/drivers/power/Kconfig b/drivers/power/Kconfig
> index 4091fb0..c7d7e8b 100644
> --- a/drivers/power/Kconfig
> +++ b/drivers/power/Kconfig
> --- /dev/null
> +++ b/drivers/power/axp288_charger.c
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License as published by
> + * the Free Software Foundation; version 2 of the License.
> + *
> + * This program is distributed in the hope that it will be useful, but
> + * WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
> + * General Public License for more details.
This states the license is GPL v2.
> +MODULE_LICENSE("GPL");
And, according to include/linux/module.h, this states the license is GPL
v2 or later. So I think either the license comment or the ident used in
the MODULE_LICENSE() macro should be changed.
Paul Bolle
next prev parent reply other threads:[~2015-04-25 9:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-24 17:06 [RFC PATCH] power: axp288_charger: axp288 charger driver Ramakrishna Pallala
2015-04-25 9:09 ` Paul Bolle [this message]
2015-04-28 11:26 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1429952957.2927.95.camel@x220 \
--to=pebolle@tiscali.nl \
--cc=jacob.jun.pan@linux.intel.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ramakrishna.pallala@intel.com \
--cc=sameo@linux.intel.com \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox