The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Paul Bolle <pebolle@tiscali.nl>
To: Ramakrishna Pallala <ramakrishna.pallala@intel.com>
Cc: linux-kernel@vger.kernel.org,
	Chanwoo Choi <cw00.choi@samsung.com>,
	Lee Jones <lee.jones@linaro.org>,
	Samuel Ortiz <sameo@linux.intel.com>,
	Jacob Pan <jacob.jun.pan@linux.intel.com>
Subject: Re: [PATCH v4] extcon-axp288: Add axp288 extcon driver support
Date: Tue, 28 Apr 2015 09:41:46 +0200	[thread overview]
Message-ID: <1430206906.2411.25.camel@x220> (raw)
In-Reply-To: <1430173962-22625-1-git-send-email-ramakrishna.pallala@intel.com>

Only a license nit.

On Tue, 2015-04-28 at 04:02 +0530, Ramakrishna Pallala wrote:
> --- /dev/null
> +++ b/drivers/extcon/extcon-axp288.c

> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License as published by
> + * the Free Software Foundation; either version 2 of the License, or
> + * (at your option) any later version.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + * GNU General Public License for more details.

This states the license is GPL v2 or later.

> +MODULE_LICENSE("GPL v2");

And, according to include/linux/module.h, this states the license is
(just) GPL v2. So I think that either the comment at the top of this
file or the ident used in the MODULE_LICENSE() macro should be changed.

Thanks,


Paul Bolle


  reply	other threads:[~2015-04-28  7:41 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-27 22:32 [PATCH v4] extcon-axp288: Add axp288 extcon driver support Ramakrishna Pallala
2015-04-28  7:41 ` Paul Bolle [this message]
2015-04-28  7:57   ` Pallala, Ramakrishna

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1430206906.2411.25.camel@x220 \
    --to=pebolle@tiscali.nl \
    --cc=cw00.choi@samsung.com \
    --cc=jacob.jun.pan@linux.intel.com \
    --cc=lee.jones@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ramakrishna.pallala@intel.com \
    --cc=sameo@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox