* [PATCH] drm/msm/mdp5: fix incorrect parameter for msm_framebuffer_iova()
@ 2015-05-20 14:57 Stephane Viau
2015-05-20 15:29 ` Rob Clark
0 siblings, 1 reply; 2+ messages in thread
From: Stephane Viau @ 2015-05-20 14:57 UTC (permalink / raw)
To: dri-devel; +Cc: linux-arm-msm, linux-kernel, robdclark, Stephane Viau
The index of ->planes[] array (3rd parameter) cannot be equal to MAX_PLANE.
This looks like a typo that is now fixed.
Signed-off-by: Stephane Viau <sviau@codeaurora.org>
---
drivers/gpu/drm/msm/mdp/mdp5/mdp5_plane.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/msm/mdp/mdp5/mdp5_plane.c b/drivers/gpu/drm/msm/mdp/mdp5/mdp5_plane.c
index 18a3d20..57b8f56 100644
--- a/drivers/gpu/drm/msm/mdp/mdp5/mdp5_plane.c
+++ b/drivers/gpu/drm/msm/mdp/mdp5/mdp5_plane.c
@@ -273,7 +273,7 @@ static void set_scanout_locked(struct drm_plane *plane,
mdp5_write(mdp5_kms, REG_MDP5_PIPE_SRC2_ADDR(pipe),
msm_framebuffer_iova(fb, mdp5_kms->id, 2));
mdp5_write(mdp5_kms, REG_MDP5_PIPE_SRC3_ADDR(pipe),
- msm_framebuffer_iova(fb, mdp5_kms->id, 4));
+ msm_framebuffer_iova(fb, mdp5_kms->id, 3));
plane->fb = fb;
}
--
Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drm/msm/mdp5: fix incorrect parameter for msm_framebuffer_iova()
2015-05-20 14:57 [PATCH] drm/msm/mdp5: fix incorrect parameter for msm_framebuffer_iova() Stephane Viau
@ 2015-05-20 15:29 ` Rob Clark
0 siblings, 0 replies; 2+ messages in thread
From: Rob Clark @ 2015-05-20 15:29 UTC (permalink / raw)
To: Stephane Viau, Dave Airlie
Cc: dri-devel@lists.freedesktop.org, linux-arm-msm,
Linux Kernel Mailing List
On Wed, May 20, 2015 at 10:57 AM, Stephane Viau <sviau@codeaurora.org> wrote:
> The index of ->planes[] array (3rd parameter) cannot be equal to MAX_PLANE.
> This looks like a typo that is now fixed.
>
> Signed-off-by: Stephane Viau <sviau@codeaurora.org>
Acked-by: Rob Clark <robdclark@gmail.com>
Dave, since it looks like you've merged my earlier fixes pull but
haven't sent to linus yet, do you mind applying this one directly on
msm-fixes?
BR,
-R
> ---
> drivers/gpu/drm/msm/mdp/mdp5/mdp5_plane.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/msm/mdp/mdp5/mdp5_plane.c b/drivers/gpu/drm/msm/mdp/mdp5/mdp5_plane.c
> index 18a3d20..57b8f56 100644
> --- a/drivers/gpu/drm/msm/mdp/mdp5/mdp5_plane.c
> +++ b/drivers/gpu/drm/msm/mdp/mdp5/mdp5_plane.c
> @@ -273,7 +273,7 @@ static void set_scanout_locked(struct drm_plane *plane,
> mdp5_write(mdp5_kms, REG_MDP5_PIPE_SRC2_ADDR(pipe),
> msm_framebuffer_iova(fb, mdp5_kms->id, 2));
> mdp5_write(mdp5_kms, REG_MDP5_PIPE_SRC3_ADDR(pipe),
> - msm_framebuffer_iova(fb, mdp5_kms->id, 4));
> + msm_framebuffer_iova(fb, mdp5_kms->id, 3));
>
> plane->fb = fb;
> }
> --
> Qualcomm Innovation Center, Inc.
>
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-05-20 15:30 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-05-20 14:57 [PATCH] drm/msm/mdp5: fix incorrect parameter for msm_framebuffer_iova() Stephane Viau
2015-05-20 15:29 ` Rob Clark
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox