* [PATCH] Staging : wilc1000 :Remove typedef from struct
@ 2015-07-31 5:32 Shraddha Barke
2015-07-31 5:46 ` Joe Perches
0 siblings, 1 reply; 6+ messages in thread
From: Shraddha Barke @ 2015-07-31 5:32 UTC (permalink / raw)
To: Dean Lee, Rachel Kim, Johnny Kim, Chris Park, Greg Kroah-Hartman,
linux-wireless, devel, linux-kernel
Cc: Shraddha Barke
This patch fixes the following checkpatch.pl warning:
WARNING: do not add new typedefs
Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
---
drivers/staging/wilc1000/coreconfigurator.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/wilc1000/coreconfigurator.c b/drivers/staging/wilc1000/coreconfigurator.c
index 0f31d63..54eb8a1 100644
--- a/drivers/staging/wilc1000/coreconfigurator.c
+++ b/drivers/staging/wilc1000/coreconfigurator.c
@@ -140,7 +140,7 @@ typedef enum {
} tenuInfoElemID;
-typedef struct {
+struct {
char *pcRespBuffer;
s32 s32MaxRespBuffLen;
s32 s32BytesRead;
--
2.1.0
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] Staging : wilc1000 :Remove typedef from struct
2015-07-31 5:32 [PATCH] Staging : wilc1000 :Remove typedef from struct Shraddha Barke
@ 2015-07-31 5:46 ` Joe Perches
0 siblings, 0 replies; 6+ messages in thread
From: Joe Perches @ 2015-07-31 5:46 UTC (permalink / raw)
To: Shraddha Barke
Cc: Dean Lee, Rachel Kim, Johnny Kim, Chris Park, Greg Kroah-Hartman,
linux-wireless, devel, linux-kernel
On Fri, 2015-07-31 at 11:02 +0530, Shraddha Barke wrote:
> This patch fixes the following checkpatch.pl warning:
>
> WARNING: do not add new typedefs
> Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
> ---
> drivers/staging/wilc1000/coreconfigurator.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/wilc1000/coreconfigurator.c b/drivers/staging/wilc1000/coreconfigurator.c
> index 0f31d63..54eb8a1 100644
> --- a/drivers/staging/wilc1000/coreconfigurator.c
> +++ b/drivers/staging/wilc1000/coreconfigurator.c
> @@ -140,7 +140,7 @@ typedef enum {
> } tenuInfoElemID;
>
>
> -typedef struct {
> +struct {
> char *pcRespBuffer;
> s32 s32MaxRespBuffLen;
> s32 s32BytesRead;
You haven't compiled this.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] Staging:wilc1000 :Remove typedef from struct
@ 2015-07-31 5:38 Shraddha Barke
2015-07-31 20:52 ` Greg Kroah-Hartman
0 siblings, 1 reply; 6+ messages in thread
From: Shraddha Barke @ 2015-07-31 5:38 UTC (permalink / raw)
To: Dean Lee, Rachel Kim, Johnny Kim, Chris Park, Greg Kroah-Hartman,
linux-wireless, devel, linux-kernel
Cc: Shraddha Barke
This patch fixes the following checkpatch.pl warning:
WARNING: do not add new typedefs
Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
---
drivers/staging/wilc1000/coreconfigurator.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/wilc1000/coreconfigurator.c b/drivers/staging/wilc1000/coreconfigurator.c
index 54eb8a1..d6ef6e1 100644
--- a/drivers/staging/wilc1000/coreconfigurator.c
+++ b/drivers/staging/wilc1000/coreconfigurator.c
@@ -88,7 +88,7 @@ typedef enum {
} tenuFrmSubtype;
/* Basic Frame Classes */
-typedef enum {
+enum {
CLASS1_FRAME_TYPE = 0x00,
CLASS2_FRAME_TYPE = 0x01,
CLASS3_FRAME_TYPE = 0x02,
--
2.1.0
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] Staging:wilc1000 :Remove typedef from struct
2015-07-31 5:38 [PATCH] Staging:wilc1000 " Shraddha Barke
@ 2015-07-31 20:52 ` Greg Kroah-Hartman
2015-08-01 4:55 ` Sudip Mukherjee
0 siblings, 1 reply; 6+ messages in thread
From: Greg Kroah-Hartman @ 2015-07-31 20:52 UTC (permalink / raw)
To: Shraddha Barke
Cc: Dean Lee, Rachel Kim, Johnny Kim, Chris Park, linux-wireless,
devel, linux-kernel
On Fri, Jul 31, 2015 at 11:08:47AM +0530, Shraddha Barke wrote:
> This patch fixes the following checkpatch.pl warning:
>
> WARNING: do not add new typedefs
>
> Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
> ---
> drivers/staging/wilc1000/coreconfigurator.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/wilc1000/coreconfigurator.c b/drivers/staging/wilc1000/coreconfigurator.c
> index 54eb8a1..d6ef6e1 100644
> --- a/drivers/staging/wilc1000/coreconfigurator.c
> +++ b/drivers/staging/wilc1000/coreconfigurator.c
> @@ -88,7 +88,7 @@ typedef enum {
> } tenuFrmSubtype;
>
> /* Basic Frame Classes */
> -typedef enum {
> +enum {
> CLASS1_FRAME_TYPE = 0x00,
> CLASS2_FRAME_TYPE = 0x01,
> CLASS3_FRAME_TYPE = 0x02,
Did you test-build this change?
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] Staging:wilc1000 :Remove typedef from struct
2015-07-31 20:52 ` Greg Kroah-Hartman
@ 2015-08-01 4:55 ` Sudip Mukherjee
2015-08-01 15:55 ` Greg Kroah-Hartman
0 siblings, 1 reply; 6+ messages in thread
From: Sudip Mukherjee @ 2015-08-01 4:55 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Shraddha Barke, Dean Lee, Rachel Kim, Chris Park, devel,
linux-wireless, Johnny Kim, linux-kernel
On Fri, Jul 31, 2015 at 01:52:13PM -0700, Greg Kroah-Hartman wrote:
> On Fri, Jul 31, 2015 at 11:08:47AM +0530, Shraddha Barke wrote:
> > This patch fixes the following checkpatch.pl warning:
> >
> > WARNING: do not add new typedefs
> >
> > Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
> > ---
<snip>
> > -typedef enum {
> > +enum {
> > CLASS1_FRAME_TYPE = 0x00,
> > CLASS2_FRAME_TYPE = 0x01,
> > CLASS3_FRAME_TYPE = 0x02,
>
> Did you test-build this change?
This enum is not used anywhere. So did not affect the build.
regards
sudip
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] Staging:wilc1000 :Remove typedef from struct
2015-08-01 4:55 ` Sudip Mukherjee
@ 2015-08-01 15:55 ` Greg Kroah-Hartman
0 siblings, 0 replies; 6+ messages in thread
From: Greg Kroah-Hartman @ 2015-08-01 15:55 UTC (permalink / raw)
To: Sudip Mukherjee
Cc: Dean Lee, Rachel Kim, Chris Park, devel, linux-wireless,
Johnny Kim, linux-kernel, Shraddha Barke
On Sat, Aug 01, 2015 at 10:25:26AM +0530, Sudip Mukherjee wrote:
> On Fri, Jul 31, 2015 at 01:52:13PM -0700, Greg Kroah-Hartman wrote:
> > On Fri, Jul 31, 2015 at 11:08:47AM +0530, Shraddha Barke wrote:
> > > This patch fixes the following checkpatch.pl warning:
> > >
> > > WARNING: do not add new typedefs
> > >
> > > Signed-off-by: Shraddha Barke <shraddha.6596@gmail.com>
> > > ---
> <snip>
> > > -typedef enum {
> > > +enum {
> > > CLASS1_FRAME_TYPE = 0x00,
> > > CLASS2_FRAME_TYPE = 0x01,
> > > CLASS3_FRAME_TYPE = 0x02,
> >
> > Did you test-build this change?
> This enum is not used anywhere. So did not affect the build.
Then it should be deleted :)
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2015-08-01 15:55 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-07-31 5:32 [PATCH] Staging : wilc1000 :Remove typedef from struct Shraddha Barke
2015-07-31 5:46 ` Joe Perches
-- strict thread matches above, loose matches on Subject: below --
2015-07-31 5:38 [PATCH] Staging:wilc1000 " Shraddha Barke
2015-07-31 20:52 ` Greg Kroah-Hartman
2015-08-01 4:55 ` Sudip Mukherjee
2015-08-01 15:55 ` Greg Kroah-Hartman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox