* [PATCH] pmem: add proper synchronization to pmem_rw_page()
@ 2015-09-16 20:52 Ross Zwisler
0 siblings, 0 replies; only message in thread
From: Ross Zwisler @ 2015-09-16 20:52 UTC (permalink / raw)
To: linux-kernel; +Cc: Ross Zwisler, Dan Williams, linux-nvdimm
pmem_rw_page() needs to call wmb_pmem() on writes to make sure that the
newly written data is durable. This flow was added to pmem_rw_bytes()
and pmem_make_request() with this commit:
commit 61031952f4c8 ("arch, x86: pmem api for ensuring durability of
persistent memory updates")
but it looks like the pmem_rw_page() path was missed.
Signed-off-by: Ross Zwisler <ross.zwisler@linux.intel.com>
---
drivers/nvdimm/pmem.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/nvdimm/pmem.c b/drivers/nvdimm/pmem.c
index b952538..0ba6a97 100644
--- a/drivers/nvdimm/pmem.c
+++ b/drivers/nvdimm/pmem.c
@@ -92,6 +92,8 @@ static int pmem_rw_page(struct block_device *bdev, sector_t sector,
struct pmem_device *pmem = bdev->bd_disk->private_data;
pmem_do_bvec(pmem, page, PAGE_CACHE_SIZE, 0, rw, sector);
+ if (rw & WRITE)
+ wmb_pmem();
page_endio(page, rw & WRITE, 0);
return 0;
--
2.1.0
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2015-09-16 20:52 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-09-16 20:52 [PATCH] pmem: add proper synchronization to pmem_rw_page() Ross Zwisler
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox