The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: gregkh@linuxfoundation.org
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH v2 06/11] parport: quoted strings should not be split
Date: Wed, 28 Oct 2015 14:41:35 +0530	[thread overview]
Message-ID: <1446023500-21292-7-git-send-email-sudipm.mukherjee@gmail.com> (raw)
In-Reply-To: <1446023500-21292-1-git-send-email-sudipm.mukherjee@gmail.com>

user visible strings should not be split as that affects the ability to
grep.

Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
---
 drivers/parport/share.c | 18 ++++++++----------
 1 file changed, 8 insertions(+), 10 deletions(-)

diff --git a/drivers/parport/share.c b/drivers/parport/share.c
index 388c138..dcad902 100644
--- a/drivers/parport/share.c
+++ b/drivers/parport/share.c
@@ -537,9 +537,8 @@ void parport_announce_port (struct parport *port)
 #endif
 
 	if (!port->dev)
-		printk(KERN_WARNING "%s: fix this legacy "
-				"no-device port driver!\n",
-				port->name);
+		printk(KERN_WARNING "%s: fix this legacy no-device port driver!\n",
+		       port->name);
 
 	parport_proc_register(port);
 	mutex_lock(&registration_lock);
@@ -778,8 +777,8 @@ parport_register_device(struct parport *port, const char *name,
 		if (port->physport->devices) {
 			spin_unlock (&port->physport->pardevice_lock);
 			printk (KERN_DEBUG
-				"%s: cannot grant exclusive access for "
-				"device %s\n", port->name, name);
+				"%s: cannot grant exclusive access for device %s\n",
+				port->name, name);
 			goto out_free_all;
 		}
 		port->flags |= PARPORT_FLAG_EXCL;
@@ -1276,9 +1275,8 @@ int parport_claim_or_block(struct pardevice *dev)
 
 #ifdef PARPORT_DEBUG_SHARING
 		if (dev->port->physport->cad != dev)
-			printk(KERN_DEBUG "%s: exiting parport_claim_or_block "
-			       "but %s owns port!\n", dev->name,
-			       dev->port->physport->cad ?
+			printk(KERN_DEBUG "%s: exiting parport_claim_or_block but %s owns port!\n",
+			       dev->name, dev->port->physport->cad ?
 			       dev->port->physport->cad->name:"nobody");
 #endif
 	}
@@ -1306,8 +1304,8 @@ void parport_release(struct pardevice *dev)
 	write_lock_irqsave(&port->cad_lock, flags);
 	if (port->cad != dev) {
 		write_unlock_irqrestore (&port->cad_lock, flags);
-		printk(KERN_WARNING "%s: %s tried to release parport "
-		       "when not owner\n", port->name, dev->name);
+		printk(KERN_WARNING "%s: %s tried to release parport when not owner\n",
+		       port->name, dev->name);
 		return;
 	}
 
-- 
1.9.1


  parent reply	other threads:[~2015-10-28  9:15 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-28  9:11 [PATCH v2 00/11] parport cleanup Sudip Mukherjee
2015-10-28  9:11 ` [PATCH v2 01/11] parport: fix a trivial typo Sudip Mukherjee
2015-10-28  9:11 ` [PATCH v2 02/11] parport: remove trailing white space Sudip Mukherjee
2015-10-28  9:11 ` [PATCH v2 03/11] parport: EXPORT_SYMBOL should follow function Sudip Mukherjee
2015-10-28  9:11 ` [PATCH v2 04/11] parport: fix coding style Sudip Mukherjee
2015-10-28  9:11 ` [PATCH v2 05/11] parport: code indent should use tabs Sudip Mukherjee
2015-10-28  9:11 ` Sudip Mukherjee [this message]
2015-10-28  9:11 ` [PATCH v2 07/11] parport: remove braces Sudip Mukherjee
2015-10-28  9:11 ` [PATCH v2 08/11] parport: remove unnecessary out of memory message Sudip Mukherjee
2015-10-28  9:11 ` [PATCH v2 09/11] parport: change style of NULL comparison Sudip Mukherjee
2015-10-28  9:11 ` [PATCH v2 10/11] parport: remove unneeded space Sudip Mukherjee
2015-10-28  9:11 ` [PATCH v2 11/11] parport: avoid assignment in if Sudip Mukherjee
2015-12-22  4:28 ` [PATCH v2 00/11] parport cleanup Sudip Mukherjee

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1446023500-21292-7-git-send-email-sudipm.mukherjee@gmail.com \
    --to=sudipm.mukherjee@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox