From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: gregkh@linuxfoundation.org
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH v2 11/11] parport: avoid assignment in if
Date: Wed, 28 Oct 2015 14:41:40 +0530 [thread overview]
Message-ID: <1446023500-21292-12-git-send-email-sudipm.mukherjee@gmail.com> (raw)
In-Reply-To: <1446023500-21292-1-git-send-email-sudipm.mukherjee@gmail.com>
It is not an usual practise to assign some value to a variable in the if
test condition.
Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
---
drivers/parport/share.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/parport/share.c b/drivers/parport/share.c
index b68f194..3308427 100644
--- a/drivers/parport/share.c
+++ b/drivers/parport/share.c
@@ -1120,7 +1120,8 @@ int parport_claim(struct pardevice *dev)
/* Preempt any current device */
write_lock_irqsave(&port->cad_lock, flags);
- if ((oldcad = port->cad) != NULL) {
+ oldcad = port->cad;
+ if (oldcad) {
if (oldcad->preempt) {
if (oldcad->preempt(oldcad->private))
goto blocked;
--
1.9.1
next prev parent reply other threads:[~2015-10-28 9:12 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-28 9:11 [PATCH v2 00/11] parport cleanup Sudip Mukherjee
2015-10-28 9:11 ` [PATCH v2 01/11] parport: fix a trivial typo Sudip Mukherjee
2015-10-28 9:11 ` [PATCH v2 02/11] parport: remove trailing white space Sudip Mukherjee
2015-10-28 9:11 ` [PATCH v2 03/11] parport: EXPORT_SYMBOL should follow function Sudip Mukherjee
2015-10-28 9:11 ` [PATCH v2 04/11] parport: fix coding style Sudip Mukherjee
2015-10-28 9:11 ` [PATCH v2 05/11] parport: code indent should use tabs Sudip Mukherjee
2015-10-28 9:11 ` [PATCH v2 06/11] parport: quoted strings should not be split Sudip Mukherjee
2015-10-28 9:11 ` [PATCH v2 07/11] parport: remove braces Sudip Mukherjee
2015-10-28 9:11 ` [PATCH v2 08/11] parport: remove unnecessary out of memory message Sudip Mukherjee
2015-10-28 9:11 ` [PATCH v2 09/11] parport: change style of NULL comparison Sudip Mukherjee
2015-10-28 9:11 ` [PATCH v2 10/11] parport: remove unneeded space Sudip Mukherjee
2015-10-28 9:11 ` Sudip Mukherjee [this message]
2015-12-22 4:28 ` [PATCH v2 00/11] parport cleanup Sudip Mukherjee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1446023500-21292-12-git-send-email-sudipm.mukherjee@gmail.com \
--to=sudipm.mukherjee@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox