From: Joe Perches <joe@perches.com>
To: Egor Uleyskiy <egor.ulieiskii@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Manohar Vanga <manohar.vanga@gmail.com>,
Martyn Welch <martyn@welchs.me.uk>,
Trivial Patch Monkey <trivial@kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers: staging: vme: Fixed code style issues
Date: Sat, 21 Nov 2015 13:38:13 -0800 [thread overview]
Message-ID: <1448141893.4505.25.camel@perches.com> (raw)
In-Reply-To: <1448141196-10060-1-git-send-email-egor.ulieiskii@gmail.com>
On Sat, 2015-11-21 at 23:26 +0200, Egor Uleyskiy wrote:
trivia:
Some might consider this patch fixes too many issues in
one patch and should be broken up into a patch series.
> > diff --git a/drivers/staging/vme/devices/vme_pio2_core.c b/drivers/staging/vme/devices/vme_pio2_core.c
[]
> retval = vme_master_set(card->window, 1, card->base, 0x10000, VME_A24,
> - (VME_SCT | VME_USER | VME_DATA), VME_D16);
> + (VME_SCT | VME_USER | VME_DATA), VME_D16);
unnecessary parentheses around VME_ constants
> @@ -343,7 +343,7 @@ static int pio2_probe(struct vme_dev *vdev)
> retval = vme_irq_request(vdev, card->irq_level, vec,
> - &pio2_int, (void *)card);
> + &pio2_int, (void *)card);
unnecessary cast to (void *) here and in other places.
You could fix these in follow-on patch(es) or revisions
like a patch set of this one.
next prev parent reply other threads:[~2015-11-21 21:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-21 21:26 [PATCH] drivers: staging: vme: Fixed code style issues Egor Uleyskiy
2015-11-21 21:38 ` Joe Perches [this message]
2015-11-24 23:29 ` Greg Kroah-Hartman
-- strict thread matches above, loose matches on Subject: below --
2015-11-13 20:01 Egor Uleyskiy
2015-11-13 23:04 ` Martyn Welch
2015-11-24 23:29 ` Greg Kroah-Hartman
2015-11-08 20:39 Egor Uleyskiy
2015-11-08 21:24 ` Greg Kroah-Hartman
2015-11-24 23:27 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1448141893.4505.25.camel@perches.com \
--to=joe@perches.com \
--cc=egor.ulieiskii@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manohar.vanga@gmail.com \
--cc=martyn@welchs.me.uk \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox