public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Martyn Welch <martyn@welchs.me.uk>
Cc: Egor Uleyskiy <egor.ulieiskii@gmail.com>,
	Manohar Vanga <manohar.vanga@gmail.com>,
	Trivial Patch Monkey <trivial@kernel.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers: staging: vme: Fixed code style issues
Date: Tue, 24 Nov 2015 15:29:10 -0800	[thread overview]
Message-ID: <20151124232910.GD17422@kroah.com> (raw)
In-Reply-To: <56466C68.4040302@welchs.me.uk>

On Fri, Nov 13, 2015 at 11:04:08PM +0000, Martyn Welch wrote:
> 
> 
> On 13/11/15 20:01, Egor Uleyskiy wrote:
> >From: Egor Uleyskiy <egor.ulieiskii@gmail.com>
> >
> >* Fixed indention
> >* Deleted extra empty lines
> >* Constructions that looks like
> >     card = kzalloc(sizeof(struct pio2_card), GFP_KERNEL);
> >   are changed to
> >     card = kzalloc(sizeof(*card), GFP_KERNEL);
> Also:
> 
>  * Removing extra bracketing from uses of the address operator
>  * Use preferred null return check style

Ick, not good, please break this up into individual patches,
one-per-type-of-fix.

thanks,

greg k-h

  reply	other threads:[~2015-11-24 23:29 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-13 20:01 [PATCH] drivers: staging: vme: Fixed code style issues Egor Uleyskiy
2015-11-13 23:04 ` Martyn Welch
2015-11-24 23:29   ` Greg Kroah-Hartman [this message]
  -- strict thread matches above, loose matches on Subject: below --
2015-11-21 21:26 Egor Uleyskiy
2015-11-21 21:38 ` Joe Perches
2015-11-24 23:29   ` Greg Kroah-Hartman
2015-11-08 20:39 Egor Uleyskiy
2015-11-08 21:24 ` Greg Kroah-Hartman
2015-11-24 23:27 ` Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151124232910.GD17422@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=egor.ulieiskii@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=manohar.vanga@gmail.com \
    --cc=martyn@welchs.me.uk \
    --cc=trivial@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox