From: "K. Y. Srinivasan" <kys@microsoft.com>
To: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
devel@linuxdriverproject.org, olaf@aepfle.de, apw@canonical.com,
vkuznets@redhat.com, jasowang@redhat.com
Cc: "K. Y. Srinivasan" <kys@microsoft.com>
Subject: [PATCH V2 12/13] Drivers: hv: vmbus: Eliminate the spin lock on the read path
Date: Wed, 27 Jan 2016 22:29:44 -0800 [thread overview]
Message-ID: <1453962585-32069-12-git-send-email-kys@microsoft.com> (raw)
In-Reply-To: <1453962585-32069-1-git-send-email-kys@microsoft.com>
The function hv_ringbuffer_read() is called always on a pre-assigned
CPU. Each chnnel is bound to a specific CPU and this function is
always called on the CPU the channel is bound. There is no need to
acquire the spin lock; get rid of this overhead.
Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
---
drivers/hv/ring_buffer.c | 18 +++++-------------
1 files changed, 5 insertions(+), 13 deletions(-)
diff --git a/drivers/hv/ring_buffer.c b/drivers/hv/ring_buffer.c
index b53702c..1145f3b 100644
--- a/drivers/hv/ring_buffer.c
+++ b/drivers/hv/ring_buffer.c
@@ -388,7 +388,6 @@ int hv_ringbuffer_read(struct hv_ring_buffer_info *inring_info,
u32 bytes_avail_toread;
u32 next_read_location = 0;
u64 prev_indices = 0;
- unsigned long flags;
struct vmpacket_descriptor desc;
u32 offset;
u32 packetlen;
@@ -397,7 +396,6 @@ int hv_ringbuffer_read(struct hv_ring_buffer_info *inring_info,
if (buflen <= 0)
return -EINVAL;
- spin_lock_irqsave(&inring_info->ring_lock, flags);
*buffer_actual_len = 0;
*requestid = 0;
@@ -412,7 +410,7 @@ int hv_ringbuffer_read(struct hv_ring_buffer_info *inring_info,
* No error is set when there is even no header, drivers are
* supposed to analyze buffer_actual_len.
*/
- goto out_unlock;
+ return ret;
}
next_read_location = hv_get_next_read_location(inring_info);
@@ -425,15 +423,11 @@ int hv_ringbuffer_read(struct hv_ring_buffer_info *inring_info,
*buffer_actual_len = packetlen;
*requestid = desc.trans_id;
- if (bytes_avail_toread < packetlen + offset) {
- ret = -EAGAIN;
- goto out_unlock;
- }
+ if (bytes_avail_toread < packetlen + offset)
+ return -EAGAIN;
- if (packetlen > buflen) {
- ret = -ENOBUFS;
- goto out_unlock;
- }
+ if (packetlen > buflen)
+ return -ENOBUFS;
next_read_location =
hv_get_next_readlocation_withoffset(inring_info, offset);
@@ -460,7 +454,5 @@ int hv_ringbuffer_read(struct hv_ring_buffer_info *inring_info,
*signal = hv_need_to_signal_on_read(bytes_avail_towrite, inring_info);
-out_unlock:
- spin_unlock_irqrestore(&inring_info->ring_lock, flags);
return ret;
}
--
1.7.4.1
next prev parent reply other threads:[~2016-01-28 4:56 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-28 6:29 [PATCH V2 00/13] Drivers: hv: vmbus: Miscellaneous fixes and enhancements K. Y. Srinivasan
2016-01-28 6:29 ` [PATCH V2 01/13] tools/hv: Use include/uapi with __EXPORTED_HEADERS__ K. Y. Srinivasan
2016-01-28 6:29 ` [PATCH V2 02/13] Drivers: hv: vmbus: avoid infinite loop in init_vp_index() K. Y. Srinivasan
2016-01-28 6:29 ` [PATCH V2 03/13] Drivers: hv: vmbus: avoid scheduling in interrupt context in vmbus_initiate_unload() K. Y. Srinivasan
2016-01-28 6:29 ` [PATCH V2 04/13] Drivers: hv: vmbus: don't manipulate with clocksources on crash K. Y. Srinivasan
2016-01-28 6:29 ` [PATCH V2 05/13] Drivers: hv: vmbus: add a helper function to set a channel's pending send size K. Y. Srinivasan
2016-01-28 6:29 ` [PATCH V2 06/13] Drivers: hv: vmbus: define the new offer type for Hyper-V socket (hvsock) K. Y. Srinivasan
2016-02-08 5:33 ` Greg KH
2016-02-10 2:44 ` Dexuan Cui
2016-01-28 6:29 ` [PATCH V2 07/13] Drivers: hv: vmbus: vmbus_sendpacket_ctl: hvsock: avoid unnecessary signaling K. Y. Srinivasan
2016-01-28 6:29 ` [PATCH V2 08/13] Drivers: hv: vmbus: define a new VMBus message type for hvsock K. Y. Srinivasan
2016-01-28 6:29 ` [PATCH V2 09/13] Drivers: hv: vmbus: add a hvsock flag in struct hv_driver K. Y. Srinivasan
2016-01-28 6:29 ` [PATCH V2 10/13] Drivers: hv: vmbus: add a per-channel rescind callback K. Y. Srinivasan
2016-01-28 6:29 ` [PATCH V2 11/13] Drivers: hv: vmbus: add an API vmbus_hvsock_device_unregister() K. Y. Srinivasan
2016-01-28 6:29 ` K. Y. Srinivasan [this message]
2016-01-28 6:29 ` [PATCH V2 13/13] Drivers: hv: vmbus: Give control over how the ring access is serialized K. Y. Srinivasan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1453962585-32069-12-git-send-email-kys@microsoft.com \
--to=kys@microsoft.com \
--cc=apw@canonical.com \
--cc=devel@linuxdriverproject.org \
--cc=gregkh@linuxfoundation.org \
--cc=jasowang@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=olaf@aepfle.de \
--cc=vkuznets@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox