public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "K. Y. Srinivasan" <kys@microsoft.com>
To: gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
	devel@linuxdriverproject.org, olaf@aepfle.de, apw@canonical.com,
	vkuznets@redhat.com, jasowang@redhat.com
Cc: "K. Y. Srinivasan" <kys@microsoft.com>
Subject: [PATCH V2 04/13] Drivers: hv: vmbus: don't manipulate with clocksources on crash
Date: Wed, 27 Jan 2016 22:29:36 -0800	[thread overview]
Message-ID: <1453962585-32069-4-git-send-email-kys@microsoft.com> (raw)
In-Reply-To: <1453962585-32069-1-git-send-email-kys@microsoft.com>

From: Vitaly Kuznetsov <vkuznets@redhat.com>

clocksource_change_rating() involves mutex usage and can't be called
in interrupt context. It also makes sense to avoid doing redundant work
on crash.

Signed-off-by: Vitaly Kuznetsov <vkuznets@redhat.com>
Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
---
 drivers/hv/hv.c |   10 ++++++++--
 1 files changed, 8 insertions(+), 2 deletions(-)

diff --git a/drivers/hv/hv.c b/drivers/hv/hv.c
index 11bca51..257de21 100644
--- a/drivers/hv/hv.c
+++ b/drivers/hv/hv.c
@@ -295,8 +295,14 @@ void hv_cleanup(void)
 	 * Cleanup the TSC page based CS.
 	 */
 	if (ms_hyperv.features & HV_X64_MSR_REFERENCE_TSC_AVAILABLE) {
-		clocksource_change_rating(&hyperv_cs_tsc, 10);
-		clocksource_unregister(&hyperv_cs_tsc);
+		/*
+		 * Crash can happen in an interrupt context and unregistering
+		 * a clocksource is impossible and redundant in this case.
+		 */
+		if (!oops_in_progress) {
+			clocksource_change_rating(&hyperv_cs_tsc, 10);
+			clocksource_unregister(&hyperv_cs_tsc);
+		}
 
 		hypercall_msr.as_uint64 = 0;
 		wrmsrl(HV_X64_MSR_REFERENCE_TSC, hypercall_msr.as_uint64);
-- 
1.7.4.1

  parent reply	other threads:[~2016-01-28  4:54 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-28  6:29 [PATCH V2 00/13] Drivers: hv: vmbus: Miscellaneous fixes and enhancements K. Y. Srinivasan
2016-01-28  6:29 ` [PATCH V2 01/13] tools/hv: Use include/uapi with __EXPORTED_HEADERS__ K. Y. Srinivasan
2016-01-28  6:29   ` [PATCH V2 02/13] Drivers: hv: vmbus: avoid infinite loop in init_vp_index() K. Y. Srinivasan
2016-01-28  6:29   ` [PATCH V2 03/13] Drivers: hv: vmbus: avoid scheduling in interrupt context in vmbus_initiate_unload() K. Y. Srinivasan
2016-01-28  6:29   ` K. Y. Srinivasan [this message]
2016-01-28  6:29   ` [PATCH V2 05/13] Drivers: hv: vmbus: add a helper function to set a channel's pending send size K. Y. Srinivasan
2016-01-28  6:29   ` [PATCH V2 06/13] Drivers: hv: vmbus: define the new offer type for Hyper-V socket (hvsock) K. Y. Srinivasan
2016-02-08  5:33     ` Greg KH
2016-02-10  2:44       ` Dexuan Cui
2016-01-28  6:29   ` [PATCH V2 07/13] Drivers: hv: vmbus: vmbus_sendpacket_ctl: hvsock: avoid unnecessary signaling K. Y. Srinivasan
2016-01-28  6:29   ` [PATCH V2 08/13] Drivers: hv: vmbus: define a new VMBus message type for hvsock K. Y. Srinivasan
2016-01-28  6:29   ` [PATCH V2 09/13] Drivers: hv: vmbus: add a hvsock flag in struct hv_driver K. Y. Srinivasan
2016-01-28  6:29   ` [PATCH V2 10/13] Drivers: hv: vmbus: add a per-channel rescind callback K. Y. Srinivasan
2016-01-28  6:29   ` [PATCH V2 11/13] Drivers: hv: vmbus: add an API vmbus_hvsock_device_unregister() K. Y. Srinivasan
2016-01-28  6:29   ` [PATCH V2 12/13] Drivers: hv: vmbus: Eliminate the spin lock on the read path K. Y. Srinivasan
2016-01-28  6:29   ` [PATCH V2 13/13] Drivers: hv: vmbus: Give control over how the ring access is serialized K. Y. Srinivasan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1453962585-32069-4-git-send-email-kys@microsoft.com \
    --to=kys@microsoft.com \
    --cc=apw@canonical.com \
    --cc=devel@linuxdriverproject.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=jasowang@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=olaf@aepfle.de \
    --cc=vkuznets@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox