From: Laxman Dewangan <ldewangan@nvidia.com>
To: <lee.jones@linaro.org>, <alexandre.belloni@free-electrons.com>,
<k.kozlowski@samsung.com>, <javier@osg.samsung.com>,
<broonie@kernel.org>, <gregkh@linuxfoundation.org>,
<a.zummo@towertech.it>
Cc: <cw00.choi@samsung.com>, <linux-kernel@vger.kernel.org>,
<rtc-linux@googlegroups.com>,
Laxman Dewangan <ldewangan@nvidia.com>
Subject: [PATCH V6 1/6] regmap: irq: dispose all virtual irq before removing domain
Date: Tue, 9 Feb 2016 17:58:22 +0530 [thread overview]
Message-ID: <1455020907-4564-2-git-send-email-ldewangan@nvidia.com> (raw)
In-Reply-To: <1455020907-4564-1-git-send-email-ldewangan@nvidia.com>
It is require to dispose all virtual irq of hwirq on chip
created on given irq domain before removing this irq domain.
Hence dispose all mapped irqs before deleting the irq domains
in regmap_del_irq_chip();
Signed-off-by: Laxman Dewangan <ldewangan@nvidia.com>
---
This is new in series. Earlier patch for adding APIs to dispose
virq via regmap is abandon and this patch took place.
The dispose of virw is added in regmap_del_irq_chip().
drivers/base/regmap/regmap-irq.c | 21 +++++++++++++++++++++
1 file changed, 21 insertions(+)
diff --git a/drivers/base/regmap/regmap-irq.c b/drivers/base/regmap/regmap-irq.c
index 9b0d202..7e1e9e8 100644
--- a/drivers/base/regmap/regmap-irq.c
+++ b/drivers/base/regmap/regmap-irq.c
@@ -655,13 +655,34 @@ EXPORT_SYMBOL_GPL(regmap_add_irq_chip);
*
* @irq: Primary IRQ for the device
* @d: regmap_irq_chip_data allocated by regmap_add_irq_chip()
+ *
+ * This function also dispose all mapped irq on chip.
*/
void regmap_del_irq_chip(int irq, struct regmap_irq_chip_data *d)
{
+ unsigned int virq;
+ int hwirq;
+
if (!d)
return;
free_irq(irq, d);
+
+ /* Dispose all virtual irq from irq domain before removing it */
+ for (hwirq = 0; hwirq < d->chip->num_irqs; hwirq++) {
+ /* Ignore hwirq if holes in the IRQ list */
+ if (!d->chip->irqs[hwirq].mask)
+ continue;
+
+ /*
+ * Find the virtual irq of hwirq on chip and if it is
+ * there then dispose it
+ */
+ virq = irq_find_mapping(d->domain, hwirq);
+ if (virq)
+ irq_dispose_mapping(virq);
+ }
+
irq_domain_remove(d->domain);
kfree(d->type_buf);
kfree(d->type_buf_def);
--
2.1.4
next prev parent reply other threads:[~2016-02-09 12:40 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-09 12:28 [PATCH V6 0/6] rtc: max77686: make max77686 rtc driver as IP driver Laxman Dewangan
2016-02-09 12:28 ` Laxman Dewangan [this message]
2016-02-09 13:27 ` [PATCH V6 1/6] regmap: irq: dispose all virtual irq before removing domain Javier Martinez Canillas
2016-02-09 13:58 ` Laxman Dewangan
2016-02-09 14:24 ` Javier Martinez Canillas
2016-02-09 15:14 ` Mark Brown
2016-02-09 15:05 ` Laxman Dewangan
2016-02-09 15:21 ` Javier Martinez Canillas
2016-02-09 14:50 ` Javier Martinez Canillas
2016-02-09 16:16 ` Applied "regmap: irq: dispose all virtual irq before removing domain" to the regmap tree Mark Brown
2016-02-09 12:28 ` [PATCH V6 2/6] rtc: max77686: fix checkpatch error Laxman Dewangan
2016-02-09 12:28 ` [PATCH V6 3/6] rtc: max77686: use rtc regmap to access RTC registers Laxman Dewangan
2016-02-09 12:28 ` [PATCH V6 4/6] rtc: max77686: avoid reference of parent device info multiple places Laxman Dewangan
2016-02-09 12:28 ` [PATCH V6 5/6] mfd: max77686: do not set i2c client data for rtc i2c client Laxman Dewangan
2016-02-09 12:28 ` [PATCH V6 6/6] rtc: max77686: move initialisation of rtc regmap, irq chip locally Laxman Dewangan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1455020907-4564-2-git-send-email-ldewangan@nvidia.com \
--to=ldewangan@nvidia.com \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@free-electrons.com \
--cc=broonie@kernel.org \
--cc=cw00.choi@samsung.com \
--cc=gregkh@linuxfoundation.org \
--cc=javier@osg.samsung.com \
--cc=k.kozlowski@samsung.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rtc-linux@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox