[BUG]: get-maintainers unable to respect parenthesis in subsystem name

[BUG]: get-maintainers unable to respect parenthesis in subsystem name

[Viresh Kumar]

Hi Joe,

I used get-maintainers today to submit few patches for OPP framework
and that is defined as below in MAINTAINERS:

OPERATING PERFORMANCE POINTS (OPP)
M:      Viresh Kumar <vireshk@kernel.org>
M:      Nishanth Menon <nm@ti.com>
M:      Stephen Boyd <sboyd@codeaurora.org>
L:      linux-pm@vger.kernel.org
S:      Maintained
T:      git git://git.kernel.org/pub/scm/linux/kernel/git/vireshk/pm.git
F:      drivers/base/power/opp/
F:      include/linux/pm_opp.h
F:      Documentation/power/opp.txt
F:      Documentation/devicetree/bindings/opp/


The parenthesis in the subsystem-name causes the cc list to look like:

Cc: linaro-kernel@lists.linaro.org,
linux-pm@vger.kernel.org,
Viresh Kumar <viresh.kumar@linaro.org>,
Krzysztof Kozlowski <k.kozlowski@samsung.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Len Brown <len.brown@intel.com>,
linux-kernel@vger.kernel.org (open list),
linux-pm@vger.kernel.org) (open list:OPERATING PERFORMANCE POINTS (OPP),
Nishanth Menon <nm@ti.com>,
Pavel Machek <pavel@ucw.cz>,
Stephen Boyd <sboyd@codeaurora.org>,
Viresh Kumar <vireshk@kernel.org>



Look at the second linux-pm entry here, it adds a ')' at the end of
the list's address
and removes it from the end of the line.

And so that becomes an invalid address to git-send-email.

Dropping () from the subsystem name fixes it though..

Thanks

--
viresh

Re: [BUG]: get-maintainers unable to respect parenthesis in subsystem name

[Joe Perches]

On Mon, 2016-02-15 at 10:27 +0530, Viresh Kumar wrote:
> Hi Joe,
> 
> I used get-maintainers today to submit few patches for OPP framework
> and that is defined as below in MAINTAINERS:
> 
> OPERATING PERFORMANCE POINTS (OPP)
> M:      Viresh Kumar <vireshk@kernel.org>
> M:      Nishanth Menon <nm@ti.com>
> M:      Stephen Boyd <sboyd@codeaurora.org>
> L:      linux-pm@vger.kernel.org
> S:      Maintained
> T:      git git://git.kernel.org/pub/scm/linux/kernel/git/vireshk/pm.git
> F:      drivers/base/power/opp/
> F:      include/linux/pm_opp.h
> F:      Documentation/power/opp.txt
> F:      Documentation/devicetree/bindings/opp/
> 
> 
> The parenthesis in the subsystem-name causes the cc list to look like:
> 
> Cc: linaro-kernel@lists.linaro.org,
> linux-pm@vger.kernel.org,
> Viresh Kumar <viresh.kumar@linaro.org>,
> Krzysztof Kozlowski <k.kozlowski@samsung.com>,
> Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
> Len Brown <len.brown@intel.com>,
> linux-kernel@vger.kernel.org (open list),
> linux-pm@vger.kernel.org) (open list:OPERATING PERFORMANCE POINTS (OPP),
> Nishanth Menon <nm@ti.com>,
> Pavel Machek <pavel@ucw.cz>,
> Stephen Boyd <sboyd@codeaurora.org>,
> Viresh Kumar <vireshk@kernel.org>
> 
> 
> 
> Look at the second linux-pm entry here, it adds a ')' at the end of
> the list's address
> and removes it from the end of the line.
> 
> And so that becomes an invalid address to git-send-email.
> 
> Dropping () from the subsystem name fixes it though..
> 
> Thanks
> 
> --
> viresh

Not what I get with current -next:

$ ./scripts/get_maintainer.pl -f Documentation/power/opp.txt 
Viresh Kumar <vireshk@kernel.org> (maintainer:OPERATING PERFORMANCE POINTS (OPP))
Nishanth Menon <nm@ti.com> (maintainer:OPERATING PERFORMANCE POINTS (OPP))
Stephen Boyd <sboyd@codeaurora.org> (maintainer:OPERATING PERFORMANCE POINTS (OPP))
"Rafael J. Wysocki" <rjw@rjwysocki.net> (supporter:SUSPEND TO RAM)
Len Brown <len.brown@intel.com> (supporter:SUSPEND TO RAM)
Pavel Machek <pavel@ucw.cz> (supporter:SUSPEND TO RAM)
linux-pm@vger.kernel.org (open list:OPERATING PERFORMANCE POINTS (OPP))
linux-kernel@vger.kernel.org (open list)

Re: [BUG]: get-maintainers unable to respect parenthesis in subsystem name

[Viresh Kumar]

On 14-02-16, 21:42, Joe Perches wrote:
> Not what I get with current -next:
> 
> $ ./scripts/get_maintainer.pl -f Documentation/power/opp.txt 
> Viresh Kumar <vireshk@kernel.org> (maintainer:OPERATING PERFORMANCE POINTS (OPP))
> Nishanth Menon <nm@ti.com> (maintainer:OPERATING PERFORMANCE POINTS (OPP))
> Stephen Boyd <sboyd@codeaurora.org> (maintainer:OPERATING PERFORMANCE POINTS (OPP))
> "Rafael J. Wysocki" <rjw@rjwysocki.net> (supporter:SUSPEND TO RAM)
> Len Brown <len.brown@intel.com> (supporter:SUSPEND TO RAM)
> Pavel Machek <pavel@ucw.cz> (supporter:SUSPEND TO RAM)
> linux-pm@vger.kernel.org (open list:OPERATING PERFORMANCE POINTS (OPP))
> linux-kernel@vger.kernel.org (open list)

Okay, its not get-maintainers, but cc-cmd that is screwing it up.

I have tested it again with following in my .gitconfig:

[sendemail]
        cccmd = scripts/get_maintainers~/scripts/cccmd

-- 
viresh

Re: [BUG]: get-maintainers unable to respect parenthesis in subsystem name

[Joe Perches]

On Mon, 2016-02-15 at 12:07 +0530, Viresh Kumar wrote:
> On 14-02-16, 21:42, Joe Perches wrote:
> > Not what I get with current -next:
> > 
> > $ ./scripts/get_maintainer.pl -f Documentation/power/opp.txt 
> > Viresh Kumar <vireshk@kernel.org> (maintainer:OPERATING PERFORMANCE POINTS (OPP))
> > Nishanth Menon <nm@ti.com> (maintainer:OPERATING PERFORMANCE POINTS (OPP))
> > Stephen Boyd <sboyd@codeaurora.org> (maintainer:OPERATING PERFORMANCE POINTS (OPP))
> > "Rafael J. Wysocki" <rjw@rjwysocki.net> (supporter:SUSPEND TO RAM)
> > Len Brown <len.brown@intel.com> (supporter:SUSPEND TO RAM)
> > Pavel Machek <pavel@ucw.cz> (supporter:SUSPEND TO RAM)
> > linux-pm@vger.kernel.org (open list:OPERATING PERFORMANCE POINTS (OPP))
> > linux-kernel@vger.kernel.org (open list)
> 
> Okay, its not get-maintainers, but cc-cmd that is screwing it up.
> 
> I have tested it again with following in my .gitconfig:
> 
> [sendemail]
>         cccmd = scripts/get_maintainers~/scripts/cccmd
> 

Then you should most likely fix your cccmd script.

Re: [BUG]: get-maintainers unable to respect parenthesis in subsystem name

[Viresh Kumar]

On 14-02-16, 23:36, Joe Perches wrote:
> On Mon, 2016-02-15 at 12:07 +0530, Viresh Kumar wrote:
> > On 14-02-16, 21:42, Joe Perches wrote:
> > > Not what I get with current -next:
> > > 
> > > $ ./scripts/get_maintainer.pl -f Documentation/power/opp.txt 
> > > Viresh Kumar <vireshk@kernel.org> (maintainer:OPERATING PERFORMANCE POINTS (OPP))
> > > Nishanth Menon <nm@ti.com> (maintainer:OPERATING PERFORMANCE POINTS (OPP))
> > > Stephen Boyd <sboyd@codeaurora.org> (maintainer:OPERATING PERFORMANCE POINTS (OPP))
> > > "Rafael J. Wysocki" <rjw@rjwysocki.net> (supporter:SUSPEND TO RAM)
> > > Len Brown <len.brown@intel.com> (supporter:SUSPEND TO RAM)
> > > Pavel Machek <pavel@ucw.cz> (supporter:SUSPEND TO RAM)
> > > linux-pm@vger.kernel.org (open list:OPERATING PERFORMANCE POINTS (OPP))
> > > linux-kernel@vger.kernel.org (open list)
> > 
> > Okay, its not get-maintainers, but cc-cmd that is screwing it up.
> > 
> > I have tested it again with following in my .gitconfig:
> > 
> > [sendemail]
> >         cccmd = scripts/get_maintainers~/scripts/cccmd
> > 
> 
> Then you should most likely fix your cccmd script.

Sorry for bad copy-paste, it looks like this instead:

[sendemail]
        cccmd = scripts/get_maintainers

So, its some issue with git I suppose. I will try logging a ticket
there.

Thanks.

-- 
viresh

Re: [BUG]: get-maintainers unable to respect parenthesis in subsystem name

[Joe Perches]

On Mon, 2016-02-15 at 13:48 +0530, Viresh Kumar wrote:
> On 14-02-16, 23:36, Joe Perches wrote:
> > On Mon, 2016-02-15 at 12:07 +0530, Viresh Kumar wrote:
> > > On 14-02-16, 21:42, Joe Perches wrote:
> > > > Not what I get with current -next:
> > > > 
> > > > $ ./scripts/get_maintainer.pl -f Documentation/power/opp.txt 
> > > > Viresh Kumar <vireshk@kernel.org> (maintainer:OPERATING
> > > > PERFORMANCE POINTS (OPP))
> > > > Nishanth Menon <nm@ti.com> (maintainer:OPERATING PERFORMANCE
> > > > POINTS (OPP))
> > > > Stephen Boyd <sboyd@codeaurora.org> (maintainer:OPERATING
> > > > PERFORMANCE POINTS (OPP))
> > > > "Rafael J. Wysocki" <rjw@rjwysocki.net> (supporter:SUSPEND TO
> > > > RAM)
> > > > Len Brown <len.brown@intel.com> (supporter:SUSPEND TO RAM)
> > > > Pavel Machek <pavel@ucw.cz> (supporter:SUSPEND TO RAM)
> > > > linux-pm@vger.kernel.org (open list:OPERATING PERFORMANCE
> > > > POINTS (OPP))
> > > > linux-kernel@vger.kernel.org (open list)
> > > 
> > > Okay, its not get-maintainers, but cc-cmd that is screwing it up.
> > > 
> > > I have tested it again with following in my .gitconfig:
> > > 
> > > [sendemail]
> > >         cccmd = scripts/get_maintainers~/scripts/cccmd
> > > 
> > 
> > Then you should most likely fix your cccmd script.
> 
> Sorry for bad copy-paste, it looks like this instead:
> 
> [sendemail]
>         cccmd = scripts/get_maintainers
> 
> So, its some issue with git I suppose. I will try logging a ticket
> there.

git send-email requires a simple list of names and addresses
without decorations like roles, commit stats or section names.

You are supposed to use something like:

tocmd = "scripts/get_maintainer.pl --nogit --nogit-fallback --norolestats --pattern-depth=1 --nol"
cccmd = "scripts/get_maintainer.pl --nogit --nogit-fallback --norolestats --nom --nor"

Re: [BUG]: get-maintainers unable to respect parenthesis in subsystem name

[Viresh Kumar]

On 15-02-16, 00:30, Joe Perches wrote:
> git send-email requires a simple list of names and addresses
> without decorations like roles, commit stats or section names.
> 
> You are supposed to use something like:
> 
> tocmd = "scripts/get_maintainer.pl --nogit --nogit-fallback --norolestats --pattern-depth=1 --nol"
> cccmd = "scripts/get_maintainer.pl --nogit --nogit-fallback --norolestats --nom --nor"

Interesting.

Looking at the number of users we have for get-maintainers now a days,
and then a number of people who feed its output it in some form to
cccmd, wouldn't it be worth documenting this somewhere in kernel
Documentation?

Honestly, I had no idea of using these options for tocmd and cccmd.
Will set them right away :)

Thanks a lot !!

-- 
viresh