* [PATCH] goldfish: Fix build error of missing ioremap on UM
@ 2016-03-03 8:13 Krzysztof Kozlowski
2016-03-04 15:48 ` Alan Cox
0 siblings, 1 reply; 2+ messages in thread
From: Krzysztof Kozlowski @ 2016-03-03 8:13 UTC (permalink / raw)
To: Jin Qian, Alan Cox, Greg Kroah-Hartman, Greg Hackmann,
Miodrag Dinic, Krzysztof Kozlowski, linux-kernel
Add missing HAS_IOMEM dependency to fix the allyesconfig build error on
ARCH=um (for x86_64):
drivers/platform/goldfish/pdev_bus.c: In function ‘goldfish_pdev_bus_probe’:
drivers/platform/goldfish/pdev_bus.c:191:18: error: implicit declaration of function ‘ioremap’ [-Werror=implicit-function-declaration]
pdev_bus_base = ioremap(pdev_bus_addr, pdev_bus_len);
Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
---
drivers/platform/goldfish/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/platform/goldfish/Kconfig b/drivers/platform/goldfish/Kconfig
index 50331e3e54f3..fefbb8370da0 100644
--- a/drivers/platform/goldfish/Kconfig
+++ b/drivers/platform/goldfish/Kconfig
@@ -1,6 +1,7 @@
menuconfig GOLDFISH
bool "Platform support for Goldfish virtual devices"
depends on X86_32 || X86_64 || ARM || ARM64 || MIPS
+ depends on HAS_IOMEM
---help---
Say Y here to get to see options for the Goldfish virtual platform.
This option alone does not add any kernel code.
--
2.5.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] goldfish: Fix build error of missing ioremap on UM
2016-03-03 8:13 [PATCH] goldfish: Fix build error of missing ioremap on UM Krzysztof Kozlowski
@ 2016-03-04 15:48 ` Alan Cox
0 siblings, 0 replies; 2+ messages in thread
From: Alan Cox @ 2016-03-04 15:48 UTC (permalink / raw)
To: Krzysztof Kozlowski, Jin Qian, Greg Kroah-Hartman, Greg Hackmann,
Miodrag Dinic, linux-kernel
On Thu, 2016-03-03 at 17:13 +0900, Krzysztof Kozlowski wrote:
> Add missing HAS_IOMEM dependency to fix the allyesconfig build error
> on
> ARCH=um (for x86_64):
>
> drivers/platform/goldfish/pdev_bus.c: In function
> ‘goldfish_pdev_bus_probe’:
> drivers/platform/goldfish/pdev_bus.c:191:18: error: implicit
> declaration of function ‘ioremap’ [-Werror=implicit-function
> -declaration]
> pdev_bus_base = ioremap(pdev_bus_addr, pdev_bus_len);
>
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Reviewed-by: Alan Cox <alan@linux.intel.com>
Thanks for that - I was trying to work out where that weird 0day
complaint was coming from.
Alan
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-03-04 15:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-03-03 8:13 [PATCH] goldfish: Fix build error of missing ioremap on UM Krzysztof Kozlowski
2016-03-04 15:48 ` Alan Cox
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox