From: Joe Perches <joe@perches.com>
To: Yingjoe Chen <yingjoe.chen@mediatek.com>,
Andy Whitcroft <apw@canonical.com>
Cc: linux-kernel@vger.kernel.org, srv_heupstream@mediatek.com
Subject: Re: [PATCH 1/3] checkpatch: add Kconfig 'default n' test
Date: Thu, 21 Apr 2016 10:16:51 -0700 [thread overview]
Message-ID: <1461259011.1918.23.camel@perches.com> (raw)
In-Reply-To: <1461245285-14918-1-git-send-email-yingjoe.chen@mediatek.com>
On Thu, 2016-04-21 at 21:28 +0800, Yingjoe Chen wrote:
> If a Kconfig config option doesn't specify 'default', the default
> will be n. Adding 'default n' is unnecessary.
>
> Add a test to warn about this.
[]
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
[]
> @@ -2600,6 +2600,13 @@ sub process {
> "Use of boolean is deprecated, please use bool instead.\n" . $herecurr);
> }
>
> +# discourage the use of default n
> + if ($realfile =~ /Kconfig/ &&
> + $line =~ /^\+\s*\bdefault\b\s*n\s*$/) {
maybe line =~ /^\+\s*default\s+n/i
Also, there are some oddities like:
arch/mips/cavium-octeon/Kconfig: default "n"
and a dozen or so uses like
default n if <foo>
next prev parent reply other threads:[~2016-04-21 17:16 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-21 13:28 [PATCH 1/3] checkpatch: add Kconfig 'default n' test Yingjoe Chen
2016-04-21 13:28 ` [PATCH 2/3] checkpatch: testing more config for Kconfig help text Yingjoe Chen
2016-04-21 17:06 ` Joe Perches
2016-04-22 13:29 ` Yingjoe Chen
2016-04-21 13:28 ` [PATCH 3/3] checkpatch: relax Kconfig help text line number threshold Yingjoe Chen
2016-04-21 17:00 ` Joe Perches
2016-04-21 17:39 ` Andi Kleen
2016-04-22 13:27 ` Yingjoe Chen
2016-04-21 17:16 ` Joe Perches [this message]
2016-04-21 18:21 ` [PATCH 1/3] checkpatch: add Kconfig 'default n' test Paul Bolle
2016-04-22 14:19 ` Yingjoe Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1461259011.1918.23.camel@perches.com \
--to=joe@perches.com \
--cc=apw@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=srv_heupstream@mediatek.com \
--cc=yingjoe.chen@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox