Re: [PATCH 1/3] checkpatch: add Kconfig 'default n' test

[Paul Bolle <pebolle@tiscali.nl>]

On do, 2016-04-21 at 10:16 -0700, Joe Perches wrote:
> Also, there are some oddities like:
> 
> arch/mips/cavium-octeon/Kconfig:        default "n"

For v4.6-rc4:
    $ git grep -n -e "default\s\+\"[mny]\"" -- "*Kconfig*"
    arch/mips/Kconfig:2232: default "y"
    arch/mips/Kconfig:2237: default "y"
    arch/mips/Kconfig:2257: default "y"
    arch/mips/Kconfig:2262: default "y"
    arch/mips/cavium-octeon/Kconfig:5:      default "n"
    arch/mips/cavium-octeon/Kconfig:30:     default "n"
    arch/mips/cavium-octeon/Kconfig:39:     default "y"
    arch/mips/cavium-octeon/Kconfig:46:     default "y"
    arch/mips/cavium-octeon/Kconfig:53:     default "y"
    arch/mips/cavium-octeon/Kconfig:60:     default "y"
    arch/mips/cavium-octeon/Kconfig:67:     default "y"
    arch/mips/cavium-octeon/Kconfig:74:     default "y"
    arch/powerpc/Kconfig:435:       default "y" if PPC_POWERNV
    arch/powerpc/Kconfig:658:       default "y" if PPC_POWERNV
    arch/powerpc/Kconfig:869:       default "n"
    drivers/crypto/Kconfig:142:     default "m"
    drivers/misc/Kconfig:784:       default "n"
    drivers/rapidio/devices/Kconfig:8:      default "n"

These appear to behave as intended, but I still think the quotes should
be dropped. (A brave soul might want to dive into the kconfig internals
and see whether they can be made less liberal in their parsing of
Kconfig files in this regard. I'm not volunteering.)


Paul Bolle