From: Joe Perches <joe@perches.com>
To: Luis de Bethencourt <luisbg@osg.samsung.com>,
linux-kernel@vger.kernel.org
Cc: johnny.kim@atmel.com, austin.shin@atmel.com,
chris.park@atmel.com, tony.cho@atmel.com, glen.lee@atmel.com,
leo.kim@atmel.com, gregkh@linuxfoundation.org,
linux-wireless@vger.kernel.org, devel@driverdev.osuosl.org
Subject: Re: [PATCH] staging: wilc1000: arrays can't be NULL
Date: Thu, 23 Jun 2016 12:24:57 -0700 [thread overview]
Message-ID: <1466709897.1847.24.camel@perches.com> (raw)
In-Reply-To: <1466704629-26084-1-git-send-email-luisbg@osg.samsung.com>
On Thu, 2016-06-23 at 18:57 +0100, Luis de Bethencourt wrote:
> hif_drv->usr_scan_req.net.net_info[i] contains found_net_info structs
> which have the following element:
> u8 bssid[6];
[]
> I am aware this patch gives a few checkpatch.pl warnings about lines being
> over 80 characters. Fixing that would be a completely different issue, and
> a lengthy one since the file has loads of them.
>
> Hopefully somebody else picks that up. Maybe I should send a hit to the
> kernelnewbies mailing list :)
Or not.
really_long_identifiers™ makes using 80 columns silly.
The hungarian could probably be converted though.
A log of the memcpy and memcpy uses could probably be
converted to ether_addr_<foo> too.
next prev parent reply other threads:[~2016-06-23 19:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-23 17:57 [PATCH] staging: wilc1000: arrays can't be NULL Luis de Bethencourt
2016-06-23 19:24 ` Joe Perches [this message]
2016-06-23 21:32 ` Luis de Bethencourt
2016-06-23 23:15 ` Julian Calaby
2016-06-23 23:50 ` Luis de Bethencourt
2016-06-23 23:54 ` Julian Calaby
2016-06-24 0:23 ` Luis de Bethencourt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1466709897.1847.24.camel@perches.com \
--to=joe@perches.com \
--cc=austin.shin@atmel.com \
--cc=chris.park@atmel.com \
--cc=devel@driverdev.osuosl.org \
--cc=glen.lee@atmel.com \
--cc=gregkh@linuxfoundation.org \
--cc=johnny.kim@atmel.com \
--cc=leo.kim@atmel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=luisbg@osg.samsung.com \
--cc=tony.cho@atmel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox