public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] usb: musb: remove duplicated actions
@ 2016-10-26 11:12 Kirill Esipov
  2016-10-26 11:16 ` Sergei Shtylyov
  0 siblings, 1 reply; 2+ messages in thread
From: Kirill Esipov @ 2016-10-26 11:12 UTC (permalink / raw)
  To: linux-kernel; +Cc: linux-usb, gregkh, b-liu, Kirill Esipov

Remove unnecessary duplicate actions (that we've got here:
19915e623458004547c1c2490b09bb923fe69337)

Signed-off-by: Kirill Esipov <yesipov@gmail.com>
---
 drivers/usb/musb/musb_core.c | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/drivers/usb/musb/musb_core.c b/drivers/usb/musb/musb_core.c
index 27dadc0..2b04f07 100644
--- a/drivers/usb/musb/musb_core.c
+++ b/drivers/usb/musb/musb_core.c
@@ -2120,12 +2120,6 @@ musb_init_controller(struct device *dev, int nIrq, void __iomem *ctrl)
 	if (musb->ops->ep_select)
 		musb->io.ep_select = musb->ops->ep_select;
 
-	/* At least tusb6010 has its own offsets */
-	if (musb->ops->ep_offset)
-		musb->io.ep_offset = musb->ops->ep_offset;
-	if (musb->ops->ep_select)
-		musb->io.ep_select = musb->ops->ep_select;
-
 	if (musb->ops->fifo_mode)
 		fifo_mode = musb->ops->fifo_mode;
 	else
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] usb: musb: remove duplicated actions
  2016-10-26 11:12 [PATCH] usb: musb: remove duplicated actions Kirill Esipov
@ 2016-10-26 11:16 ` Sergei Shtylyov
  0 siblings, 0 replies; 2+ messages in thread
From: Sergei Shtylyov @ 2016-10-26 11:16 UTC (permalink / raw)
  To: Kirill Esipov, linux-kernel; +Cc: linux-usb, gregkh, b-liu

Hello.

On 10/26/2016 2:12 PM, Kirill Esipov wrote:

> Remove unnecessary duplicate actions (that we've got here:
> 19915e623458004547c1c2490b09bb923fe69337)

    You should also specify the commit's summary line in (""). And it's enough 
to specify 12 digits of SHA1 ID.

> Signed-off-by: Kirill Esipov <yesipov@gmail.com>
[...]

MBR, Sergei

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2016-10-26 11:16 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-10-26 11:12 [PATCH] usb: musb: remove duplicated actions Kirill Esipov
2016-10-26 11:16 ` Sergei Shtylyov

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox