From: Joe Perches <joe@perches.com>
To: Julia Lawall <julia.lawall@lip6.fr>,
simran singhal <singhalsimran0@gmail.com>
Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org, outreachy-kernel@googlegroups.com
Subject: Re: [Outreachy kernel] [PATCH 6/6] staging: rtl8192e: Removed unnecessary parentheses
Date: Sat, 18 Feb 2017 11:21:34 -0800 [thread overview]
Message-ID: <1487445694.2198.26.camel@perches.com> (raw)
In-Reply-To: <alpine.DEB.2.20.1702182012240.2383@hadrien>
On Sat, 2017-02-18 at 20:12 +0100, Julia Lawall wrote:
> On Sun, 19 Feb 2017, simran singhal wrote:
> > Extra parentheses were causing checkpatch issues
> > and were removed.
[]
> > diff --git a/drivers/staging/rtl8192e/rtl819x_HTProc.c b/drivers/staging/rtl8192e/rtl819x_HTProc.c
[]
> > @@ -663,13 +663,13 @@ void HTInitializeHTInfo(struct rtllib_device *ieee)
> > pHTInfo->CurrentMPDUDensity = pHTInfo->MPDU_Density;
> > pHTInfo->CurrentAMPDUFactor = pHTInfo->AMPDU_Factor;
> >
> > - memset((void *)(&(pHTInfo->SelfHTCap)), 0,
> > + memset((void *)(&pHTInfo->SelfHTCap), 0,
>
> You don't need the parens around the argument of the cast either.
Nor need the cast at all.
memset(&pHTInfo->SelfHTCap, 0, sizeof(pHTInfo->SelfHTCap));
etc...
next prev parent reply other threads:[~2017-02-18 19:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-18 18:36 [PATCH 6/6] staging: rtl8192e: Removed unnecessary parentheses simran singhal
2017-02-18 19:12 ` [Outreachy kernel] " Julia Lawall
2017-02-18 19:21 ` Joe Perches [this message]
2017-02-18 19:46 ` Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1487445694.2198.26.camel@perches.com \
--to=joe@perches.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=julia.lawall@lip6.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=outreachy-kernel@googlegroups.com \
--cc=singhalsimran0@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox