From: Joe Perches <joe@perches.com>
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: seq_file optimization?
Date: Fri, 30 Jun 2017 19:48:17 -0700 [thread overview]
Message-ID: <1498877297.2353.10.camel@perches.com> (raw)
About this commit in mm:
---------------------------------------------------
commit c1aca87fb3f84a813fb3dda656bbee583c9c87a3
Author: Alexey Dobriyan <adobriyan@gmail.com>
Date: Fri Jun 30 11:02:04 2017 +1000
fs/seq_file.c: delete small-value optimization
num_to_str() optimizes printing small integers [0..9], so the same check
higher in callchain is unnecessary.
---------------------------------------------------
Is removing this optimization really the same speed?
I don't think so.
The num_to_str call still does multiple moves of
memory to the output, this is a single byte copy.
reply other threads:[~2017-07-01 2:48 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1498877297.2353.10.camel@perches.com \
--to=joe@perches.com \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox