public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* seq_file optimization?
@ 2017-07-01  2:48 Joe Perches
  0 siblings, 0 replies; only message in thread
From: Joe Perches @ 2017-07-01  2:48 UTC (permalink / raw)
  To: Alexey Dobriyan; +Cc: Andrew Morton, LKML

About this commit in mm:

---------------------------------------------------
commit c1aca87fb3f84a813fb3dda656bbee583c9c87a3
Author: Alexey Dobriyan <adobriyan@gmail.com>
Date:   Fri Jun 30 11:02:04 2017 +1000

    fs/seq_file.c: delete small-value optimization
    
    num_to_str() optimizes printing small integers [0..9], so the same check
    higher in callchain is unnecessary.
---------------------------------------------------

Is removing this optimization really the same speed?

I don't think so.

The num_to_str call still does multiple moves of
memory to the output, this is a single byte copy.

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2017-07-01  2:48 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-07-01  2:48 seq_file optimization? Joe Perches

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox