From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: tglx@linutronix.de, mingo@kernel.org
Cc: dingtianhong@huawei.com, matt.redfearn@imgtec.com,
dan.carpenter@oracle.com, garsilva@embeddedor.com,
mka@chromium.org, linux-kernel@vger.kernel.org,
Frans Klaver <fransklaver@gmail.com>
Subject: [PATCH 2/5] clocksource/drivers/em_sti: Fix error return codes in em_sti_probe()
Date: Fri, 11 Aug 2017 16:17:38 +0200 [thread overview]
Message-ID: <1502461061-28065-2-git-send-email-daniel.lezcano@linaro.org> (raw)
In-Reply-To: <1502461061-28065-1-git-send-email-daniel.lezcano@linaro.org>
From: "Gustavo A. R. Silva" <garsilva@embeddedor.com>
Propagate the return values of platform_get_irq and devm_request_irq on
failure.
Cc: Frans Klaver <fransklaver@gmail.com>
Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
---
drivers/clocksource/em_sti.c | 11 ++++++-----
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/drivers/clocksource/em_sti.c b/drivers/clocksource/em_sti.c
index bc48cbf..269db74 100644
--- a/drivers/clocksource/em_sti.c
+++ b/drivers/clocksource/em_sti.c
@@ -305,7 +305,7 @@ static int em_sti_probe(struct platform_device *pdev)
irq = platform_get_irq(pdev, 0);
if (irq < 0) {
dev_err(&pdev->dev, "failed to get irq\n");
- return -EINVAL;
+ return irq;
}
/* map memory, let base point to the STI instance */
@@ -314,11 +314,12 @@ static int em_sti_probe(struct platform_device *pdev)
if (IS_ERR(p->base))
return PTR_ERR(p->base);
- if (devm_request_irq(&pdev->dev, irq, em_sti_interrupt,
- IRQF_TIMER | IRQF_IRQPOLL | IRQF_NOBALANCING,
- dev_name(&pdev->dev), p)) {
+ ret = devm_request_irq(&pdev->dev, irq, em_sti_interrupt,
+ IRQF_TIMER | IRQF_IRQPOLL | IRQF_NOBALANCING,
+ dev_name(&pdev->dev), p);
+ if (ret) {
dev_err(&pdev->dev, "failed to request low IRQ\n");
- return -ENOENT;
+ return ret;
}
/* get hold of clock */
--
2.7.4
next prev parent reply other threads:[~2017-08-11 14:18 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-11 14:15 Daniel Lezcano
2017-08-11 14:16 ` [GIT PULL] clockevents: fixes for 4.13-rc4 Daniel Lezcano
2017-08-11 18:43 ` Linus Torvalds
2017-08-11 21:44 ` Daniel Lezcano
2017-08-11 22:57 ` Linus Torvalds
2017-08-11 23:30 ` Ingo Molnar
2017-08-11 14:17 ` [PATCH 1/5] clocksource/drivers/arm_arch_timer: Fix mem frame loop initialization Daniel Lezcano
2017-08-11 14:17 ` Daniel Lezcano [this message]
2017-08-11 14:17 ` [PATCH 3/5] clocksource/drivers/timer-of: Checking for IS_ERR() instead of NULL Daniel Lezcano
2017-08-11 14:17 ` [PATCH 4/5] clocksource/drivers/Kconfig: Fix CLKSRC_PISTACHIO dependencies Daniel Lezcano
2017-08-11 14:17 ` [PATCH 5/5] clocksource/drivers/arm_arch_timer: Avoid infinite recursion when ftrace is enabled Daniel Lezcano
2017-08-13 9:42 ` [GIT PULL] clockevents: fixes for 4.13-rc4 Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1502461061-28065-2-git-send-email-daniel.lezcano@linaro.org \
--to=daniel.lezcano@linaro.org \
--cc=dan.carpenter@oracle.com \
--cc=dingtianhong@huawei.com \
--cc=fransklaver@gmail.com \
--cc=garsilva@embeddedor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=matt.redfearn@imgtec.com \
--cc=mingo@kernel.org \
--cc=mka@chromium.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox