public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: tglx@linutronix.de, mingo@kernel.org
Cc: dingtianhong@huawei.com, matt.redfearn@imgtec.com,
	dan.carpenter@oracle.com, garsilva@embeddedor.com,
	mka@chromium.org, linux-kernel@vger.kernel.org
Subject: [PATCH 4/5] clocksource/drivers/Kconfig: Fix CLKSRC_PISTACHIO dependencies
Date: Fri, 11 Aug 2017 16:17:40 +0200	[thread overview]
Message-ID: <1502461061-28065-4-git-send-email-daniel.lezcano@linaro.org> (raw)
In-Reply-To: <1502461061-28065-1-git-send-email-daniel.lezcano@linaro.org>

From: Matt Redfearn <matt.redfearn@imgtec.com>

In v4.13, CLKSRC_PISTACHIO can select TIMER_OF on architectures without
GENERIC_CLOCKEVENTS, resulting in a struct clock_event_device missing
some required features and build breakage compiling timer_of.c. One of
the symbols selecting TIMER_OF is CLKSRC_PISTACHIO, so add the
dependency on GENERIC_CLOCKEVENTS.

Thanks to kbuild test robot for finding this error
(https://lkml.org/lkml/2017/7/16/249)

Signed-off-by: Matt Redfearn <matt.redfearn@imgtec.com>
Suggested-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
---
 drivers/clocksource/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig
index fcae5ca..54a67f8 100644
--- a/drivers/clocksource/Kconfig
+++ b/drivers/clocksource/Kconfig
@@ -262,7 +262,7 @@ config CLKSRC_LPC32XX
 
 config CLKSRC_PISTACHIO
 	bool "Clocksource for Pistachio SoC" if COMPILE_TEST
-	depends on HAS_IOMEM
+	depends on GENERIC_CLOCKEVENTS && HAS_IOMEM
 	select TIMER_OF
 	help
 	  Enables the clocksource for the Pistachio SoC.
-- 
2.7.4

  parent reply	other threads:[~2017-08-11 14:18 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-11 14:15 Daniel Lezcano
2017-08-11 14:16 ` [GIT PULL] clockevents: fixes for 4.13-rc4 Daniel Lezcano
2017-08-11 18:43   ` Linus Torvalds
2017-08-11 21:44     ` Daniel Lezcano
2017-08-11 22:57       ` Linus Torvalds
2017-08-11 23:30       ` Ingo Molnar
2017-08-11 14:17 ` [PATCH 1/5] clocksource/drivers/arm_arch_timer: Fix mem frame loop initialization Daniel Lezcano
2017-08-11 14:17   ` [PATCH 2/5] clocksource/drivers/em_sti: Fix error return codes in em_sti_probe() Daniel Lezcano
2017-08-11 14:17   ` [PATCH 3/5] clocksource/drivers/timer-of: Checking for IS_ERR() instead of NULL Daniel Lezcano
2017-08-11 14:17   ` Daniel Lezcano [this message]
2017-08-11 14:17   ` [PATCH 5/5] clocksource/drivers/arm_arch_timer: Avoid infinite recursion when ftrace is enabled Daniel Lezcano
2017-08-13  9:42 ` [GIT PULL] clockevents: fixes for 4.13-rc4 Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1502461061-28065-4-git-send-email-daniel.lezcano@linaro.org \
    --to=daniel.lezcano@linaro.org \
    --cc=dan.carpenter@oracle.com \
    --cc=dingtianhong@huawei.com \
    --cc=garsilva@embeddedor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=matt.redfearn@imgtec.com \
    --cc=mingo@kernel.org \
    --cc=mka@chromium.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox