public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: srinivas pandruvada <srinivas.pandruvada@linux.intel.com>
To: Sanjay Chitroda <sanjayembeddedse@gmail.com>,
	jikos@kernel.org,  jic23@kernel.org
Cc: dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org,
	 sakari.ailus@linux.intel.com, linux-input@vger.kernel.org,
	 linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
	Zhang Lixu <lixu.zhang@intel.com>
Subject: Re: [PATCH v2 0/4] iio: introduce devm_ API for hid sensro setup and cleanup
Date: Fri, 01 May 2026 04:53:38 -0700	[thread overview]
Message-ID: <15509f5e5a6642d2a4b0ccc13bc7d40d3b79f72a.camel@linux.intel.com> (raw)
In-Reply-To: <20260429175918.2541914-1-sanjayembedded@gmail.com>

+ Lixu

On Wed, 2026-04-29 at 23:29 +0530, Sanjay Chitroda wrote:
> From: Sanjay Chitroda <sanjayembeddedse@gmail.com>
> 
> Key highlights:
> - Prepare change as pre-requisite for devm conversion for HID IIO
>   drivers by removing redundant argument
> - Add devm API to setup trigger and clenaup resource using
>   devm_add_action_or_reset()
> - few sample driver update using devm conversion to auto release
> resource
> 

devm_* calls are fine but needs tests particularly when forces ISH PCI
drivers unbind, while iio-sensor-proxy has open sessions.

Lixu, Please check.

Thanks,
Srinivas



> changes in v2:
> - Following input from Jonathan and Andy, squash initial patch v1
>   series in single change as individual change should not break
> anything
> - Add devm API support and two driver using the same
> - v1 series ->
> https://lore.kernel.org/all/20260428071613.1134053-1-sanjayembedded@gmail.com/
> 
> Testing:
>   - Compiled with W=1
>   - Build-tested on QEMU x86_64
> 
> Based on further feedback and reviews, I would extend this series to
> convert all HID IIO driver to use devm_* API.
> 
> Thanks,
> Sanjay Chitroda
> 
> Sanjay Chitroda (4):
>   iio: hid-sensors: drop redundant iio_dev argument
>   iio: hid-sensors: introduce device managed API
>   iio: gyro: drop hid_sensor_remove_trigger() using devm API
>   iio: humidity: drop hid_sensor_remove_trigger() using devm API
> 
>  drivers/iio/accel/hid-sensor-accel-3d.c       |  4 +--
>  .../common/hid-sensors/hid-sensor-trigger.c   | 27
> +++++++++++++++++--
>  .../common/hid-sensors/hid-sensor-trigger.h   |  5 ++--
>  drivers/iio/gyro/hid-sensor-gyro-3d.c         | 10 +++----
>  drivers/iio/humidity/hid-sensor-humidity.c    | 10 +++----
>  drivers/iio/light/hid-sensor-als.c            |  4 +--
>  drivers/iio/light/hid-sensor-prox.c           |  4 +--
>  drivers/iio/magnetometer/hid-sensor-magn-3d.c |  4 +--
>  drivers/iio/orientation/hid-sensor-incl-3d.c  |  4 +--
>  drivers/iio/orientation/hid-sensor-rotation.c |  4 +--
>  .../position/hid-sensor-custom-intel-hinge.c  |  4 +--
>  drivers/iio/pressure/hid-sensor-press.c       |  4 +--
>  .../iio/temperature/hid-sensor-temperature.c  |  4 +--
>  13 files changed, 52 insertions(+), 36 deletions(-)
> 
> 
> base-commit: eade2b843d9b1f668fc1775f15611bb0a1999cd9

      parent reply	other threads:[~2026-05-01 11:53 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-29 17:59 [PATCH v2 0/4] iio: introduce devm_ API for hid sensro setup and cleanup Sanjay Chitroda
2026-04-29 17:59 ` [PATCH v2 1/4] iio: hid-sensors: drop redundant iio_dev argument Sanjay Chitroda
2026-04-29 17:59 ` [PATCH v2 2/4] iio: hid-sensors: introduce device managed API Sanjay Chitroda
2026-04-29 19:31   ` Andy Shevchenko
2026-04-30 19:30     ` Sanjay Chitroda
2026-05-01 12:34       ` Andy Shevchenko
2026-04-29 17:59 ` [PATCH v2 3/4] iio: gyro: drop hid_sensor_remove_trigger() using devm API Sanjay Chitroda
2026-04-29 17:59 ` [PATCH v2 4/4] iio: humidity: " Sanjay Chitroda
2026-04-29 19:33   ` Andy Shevchenko
2026-04-30 19:21     ` Sanjay Chitroda
2026-05-01 18:25       ` Andy Shevchenko
2026-04-29 19:35 ` [PATCH v2 0/4] iio: introduce devm_ API for hid sensro setup and cleanup Andy Shevchenko
2026-05-01 11:53 ` srinivas pandruvada [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=15509f5e5a6642d2a4b0ccc13bc7d40d3b79f72a.camel@linux.intel.com \
    --to=srinivas.pandruvada@linux.intel.com \
    --cc=andy@kernel.org \
    --cc=dlechner@baylibre.com \
    --cc=jic23@kernel.org \
    --cc=jikos@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lixu.zhang@intel.com \
    --cc=nuno.sa@analog.com \
    --cc=sakari.ailus@linux.intel.com \
    --cc=sanjayembeddedse@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox