From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Sanjay Chitroda <sanjayembeddedse@gmail.com>
Cc: jikos@kernel.org, jic23@kernel.org,
srinivas.pandruvada@linux.intel.com, dlechner@baylibre.com,
nuno.sa@analog.com, andy@kernel.org,
sakari.ailus@linux.intel.com, linux-input@vger.kernel.org,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 4/4] iio: humidity: drop hid_sensor_remove_trigger() using devm API
Date: Wed, 29 Apr 2026 22:33:56 +0300 [thread overview]
Message-ID: <afJdJIQS1vwOcaGT@ashevche-desk.local> (raw)
In-Reply-To: <20260429175918.2541914-5-sanjayembedded@gmail.com>
On Wed, Apr 29, 2026 at 11:29:18PM +0530, Sanjay Chitroda wrote:
> Use devm_hid_sensor_setup_trigger() to automatically release resource
> during fail, unbind or removal of driver using devres framework.
>
> This simplify the setup, remove goto, avoid manual resource cleanup in
> teardown path.
...
> - ret = hid_sensor_setup_trigger(indio_dev, name,
> - &humid_st->common_attributes);
> + ret = devm_hid_sensor_setup_trigger(&indio_dev->dev, indio_dev, name,
> + &humid_st->common_attributes);
I believe the first parameter is utterly wrong here.
Or other way around, same issue but in the previous patch.
> if (ret)
> return ret;
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-04-29 19:34 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-29 17:59 [PATCH v2 0/4] iio: introduce devm_ API for hid sensro setup and cleanup Sanjay Chitroda
2026-04-29 17:59 ` [PATCH v2 1/4] iio: hid-sensors: drop redundant iio_dev argument Sanjay Chitroda
2026-04-29 17:59 ` [PATCH v2 2/4] iio: hid-sensors: introduce device managed API Sanjay Chitroda
2026-04-29 19:31 ` Andy Shevchenko
2026-04-30 19:30 ` Sanjay Chitroda
2026-05-01 12:34 ` Andy Shevchenko
2026-04-29 17:59 ` [PATCH v2 3/4] iio: gyro: drop hid_sensor_remove_trigger() using devm API Sanjay Chitroda
2026-04-29 17:59 ` [PATCH v2 4/4] iio: humidity: " Sanjay Chitroda
2026-04-29 19:33 ` Andy Shevchenko [this message]
2026-04-30 19:21 ` Sanjay Chitroda
2026-05-01 18:25 ` Andy Shevchenko
2026-05-05 16:32 ` Jonathan Cameron
2026-04-29 19:35 ` [PATCH v2 0/4] iio: introduce devm_ API for hid sensro setup and cleanup Andy Shevchenko
2026-05-01 11:53 ` srinivas pandruvada
2026-05-05 16:33 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=afJdJIQS1vwOcaGT@ashevche-desk.local \
--to=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=jikos@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=sakari.ailus@linux.intel.com \
--cc=sanjayembeddedse@gmail.com \
--cc=srinivas.pandruvada@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox