[PATCH] drivers: pcmcia: This patch fix the following checkpatch warning.

[PATCH] drivers: pcmcia: This patch fix the following checkpatch warning.

[Mohan Kumar]

Switch hardcoded function name with a reference to __func__ making the
code more maintainable

WARNING: Prefer using '"%s...", __func__' to using function's name, in a
string

Signed-off-by: Mohan Kumar <mohankumar718@gmail.com>
---
 drivers/pcmcia/tcic.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/pcmcia/tcic.c b/drivers/pcmcia/tcic.c
index 1a0e3f0987..fc653e7 100644
--- a/drivers/pcmcia/tcic.c
+++ b/drivers/pcmcia/tcic.c
@@ -540,7 +540,7 @@ static irqreturn_t tcic_interrupt(int irq, void *dev)
     } else
 	active = 1;
 
-    pr_debug("tcic_interrupt()\n");
+    pr_debug("%s()\n", __func__);
     
     for (i = 0; i < sockets; i++) {
 	psock = socket_table[i].psock;
@@ -583,7 +583,7 @@ static irqreturn_t tcic_interrupt(int irq, void *dev)
 
 static void tcic_timer(struct timer_list *unused)
 {
-    pr_debug("tcic_timer()\n");
+    pr_debug("%s()\n", __func__);
     tcic_timer_pending = 0;
     tcic_interrupt(0, NULL);
 } /* tcic_timer */
-- 
2.7.4

Re: [PATCH] drivers: pcmcia: This patch fix the following checkpatch warning.

[Dominik Brodowski]

On Tue, Apr 16, 2019 at 08:45:44PM +0300, Mohan Kumar wrote:
> Switch hardcoded function name with a reference to __func__ making the
> code more maintainable

Thanks for your patch. Are there any other patches pending to this driver?

As noted in Kconfig, the TCIC host briges "are only found on a handful of
old systems". Therefore, I am a bit reluctant to apply this patch,
especially as the much more in this file does not adhere to current kernel
CodingStyle practices.

Thanks,
	Dominik