From: Chaotian Jing <chaotian.jing@mediatek.com>
To: NeilBrown <neil@brown.name>
Cc: Ulf Hansson <ulf.hansson@linaro.org>, <linux-mmc@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <thirtythreeforty@gmail.com>
Subject: Re: [PATCH 4/4] mmc: mtk-sd: select REGULATOR
Date: Sun, 5 May 2019 15:52:52 +0800 [thread overview]
Message-ID: <1557042772.18628.36.camel@mhfsdcap03> (raw)
In-Reply-To: <155696549700.8632.10790498625986428152.stgit@noble.brown>
On Sat, 2019-05-04 at 20:24 +1000, NeilBrown wrote:
> The mtk-sd driver requires a regulator to be present, even if it is
> the "fixed" regulator. So select REGULATOR to make it hard to build
> unusable configurations.
>
> Signed-off-by: NeilBrown <neil@brown.name>
Reviewed-by:Chaotian Jing <chaotian.jing@mediatek.com>
> ---
> drivers/mmc/host/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig
> index 9c01310a0d2e..1249cde7004d 100644
> --- a/drivers/mmc/host/Kconfig
> +++ b/drivers/mmc/host/Kconfig
> @@ -941,6 +941,7 @@ config MMC_BCM2835
> config MMC_MTK
> tristate "MediaTek SD/MMC Card Interface support"
> depends on HAS_DMA
> + select REGULATOR
> help
> This selects the MediaTek(R) Secure digital and Multimedia card Interface.
> If you have a machine with a integrated SD/MMC card reader, say Y or M here.
>
>
next prev parent reply other threads:[~2019-05-05 7:53 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-04 10:24 [PATCH 0/4] mtk-sd enhancement to support MT7621 - V2 NeilBrown
2019-05-04 10:24 ` [PATCH 2/4] mmc: mtk-sd: add support for config found in mt7620 family SOCs NeilBrown
2019-05-05 7:49 ` Chaotian Jing
2019-05-04 10:24 ` [PATCH 1/4] mmc: mtk-sd: don't hard-code interrupt trigger type NeilBrown
2019-05-05 7:43 ` Chaotian Jing
2019-05-04 10:24 ` [PATCH 4/4] mmc: mtk-sd: select REGULATOR NeilBrown
2019-05-05 7:52 ` Chaotian Jing [this message]
2019-05-04 10:24 ` [PATCH 3/4] mmc: mtk-sd: enable internal card-detect logic NeilBrown
2019-05-05 7:52 ` Chaotian Jing
2019-05-06 9:51 ` [PATCH 0/4] mtk-sd enhancement to support MT7621 - V2 Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1557042772.18628.36.camel@mhfsdcap03 \
--to=chaotian.jing@mediatek.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=neil@brown.name \
--cc=thirtythreeforty@gmail.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox