* [PATCH] usb: typec: tcpm: turn tcpm_ams_finish into void function
@ 2021-03-08 6:21 Yang Li
2021-03-08 6:30 ` Guenter Roeck
2021-03-08 8:59 ` Sergei Shtylyov
0 siblings, 2 replies; 3+ messages in thread
From: Yang Li @ 2021-03-08 6:21 UTC (permalink / raw)
To: linux; +Cc: heikki.krogerus, gregkh, linux-usb, linux-kernel, Yang Li
This function always return '0' and no callers use the return value.
So make it a void function.
This eliminates the following coccicheck warning:
./drivers/usb/typec/tcpm/tcpm.c:778:5-8: Unneeded variable: "ret".
Return "0" on line 794
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
---
drivers/usb/typec/tcpm/tcpm.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/usb/typec/tcpm/tcpm.c b/drivers/usb/typec/tcpm/tcpm.c
index be0b646..6ee984e 100644
--- a/drivers/usb/typec/tcpm/tcpm.c
+++ b/drivers/usb/typec/tcpm/tcpm.c
@@ -773,10 +773,8 @@ static enum typec_cc_status tcpm_rp_cc(struct tcpm_port *port)
return TYPEC_CC_RP_DEF;
}
-static int tcpm_ams_finish(struct tcpm_port *port)
+static void tcpm_ams_finish(struct tcpm_port *port)
{
- int ret = 0;
-
tcpm_log(port, "AMS %s finished", tcpm_ams_str[port->ams]);
if (port->pd_capable && port->pwr_role == TYPEC_SOURCE) {
@@ -791,7 +789,7 @@ static int tcpm_ams_finish(struct tcpm_port *port)
port->in_ams = false;
port->ams = NONE_AMS;
- return ret;
+ return;
}
static int tcpm_pd_transmit(struct tcpm_port *port,
--
1.8.3.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] usb: typec: tcpm: turn tcpm_ams_finish into void function
2021-03-08 6:21 [PATCH] usb: typec: tcpm: turn tcpm_ams_finish into void function Yang Li
@ 2021-03-08 6:30 ` Guenter Roeck
2021-03-08 8:59 ` Sergei Shtylyov
1 sibling, 0 replies; 3+ messages in thread
From: Guenter Roeck @ 2021-03-08 6:30 UTC (permalink / raw)
To: Yang Li; +Cc: heikki.krogerus, gregkh, linux-usb, linux-kernel
On 3/7/21 10:21 PM, Yang Li wrote:
> This function always return '0' and no callers use the return value.
> So make it a void function.
>
> This eliminates the following coccicheck warning:
> ./drivers/usb/typec/tcpm/tcpm.c:778:5-8: Unneeded variable: "ret".
> Return "0" on line 794
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
> ---
> drivers/usb/typec/tcpm/tcpm.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/usb/typec/tcpm/tcpm.c b/drivers/usb/typec/tcpm/tcpm.c
> index be0b646..6ee984e 100644
> --- a/drivers/usb/typec/tcpm/tcpm.c
> +++ b/drivers/usb/typec/tcpm/tcpm.c
> @@ -773,10 +773,8 @@ static enum typec_cc_status tcpm_rp_cc(struct tcpm_port *port)
> return TYPEC_CC_RP_DEF;
> }
>
> -static int tcpm_ams_finish(struct tcpm_port *port)
> +static void tcpm_ams_finish(struct tcpm_port *port)
> {
> - int ret = 0;
> -
> tcpm_log(port, "AMS %s finished", tcpm_ams_str[port->ams]);
>
> if (port->pd_capable && port->pwr_role == TYPEC_SOURCE) {
> @@ -791,7 +789,7 @@ static int tcpm_ams_finish(struct tcpm_port *port)
> port->in_ams = false;
> port->ams = NONE_AMS;
>
> - return ret;
> + return;
Unnecessary return statement
Guenter
> }
>
> static int tcpm_pd_transmit(struct tcpm_port *port,
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] usb: typec: tcpm: turn tcpm_ams_finish into void function
2021-03-08 6:21 [PATCH] usb: typec: tcpm: turn tcpm_ams_finish into void function Yang Li
2021-03-08 6:30 ` Guenter Roeck
@ 2021-03-08 8:59 ` Sergei Shtylyov
1 sibling, 0 replies; 3+ messages in thread
From: Sergei Shtylyov @ 2021-03-08 8:59 UTC (permalink / raw)
To: Yang Li, linux; +Cc: heikki.krogerus, gregkh, linux-usb, linux-kernel
Hello!
On 08.03.2021 9:21, Yang Li wrote:
> This function always return '0' and no callers use the return value.
Returns.
> So make it a void function.
>
> This eliminates the following coccicheck warning:
> ./drivers/usb/typec/tcpm/tcpm.c:778:5-8: Unneeded variable: "ret".
> Return "0" on line 794
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
> ---
> drivers/usb/typec/tcpm/tcpm.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/usb/typec/tcpm/tcpm.c b/drivers/usb/typec/tcpm/tcpm.c
> index be0b646..6ee984e 100644
> --- a/drivers/usb/typec/tcpm/tcpm.c
> +++ b/drivers/usb/typec/tcpm/tcpm.c
> @@ -773,10 +773,8 @@ static enum typec_cc_status tcpm_rp_cc(struct tcpm_port *port)
> return TYPEC_CC_RP_DEF;
> }
>
> -static int tcpm_ams_finish(struct tcpm_port *port)
> +static void tcpm_ams_finish(struct tcpm_port *port)
> {
> - int ret = 0;
> -
> tcpm_log(port, "AMS %s finished", tcpm_ams_str[port->ams]);
>
> if (port->pd_capable && port->pwr_role == TYPEC_SOURCE) {
> @@ -791,7 +789,7 @@ static int tcpm_ams_finish(struct tcpm_port *port)
> port->in_ams = false;
> port->ams = NONE_AMS;
>
> - return ret;
> + return;
Just remove that *return*.
> }
[...]
MBR, Sergei
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-03-08 9:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-03-08 6:21 [PATCH] usb: typec: tcpm: turn tcpm_ams_finish into void function Yang Li
2021-03-08 6:30 ` Guenter Roeck
2021-03-08 8:59 ` Sergei Shtylyov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox