[PATCH] ALSA: seq: oss: Fix inconsistent indenting

[PATCH] ALSA: seq: oss: Fix inconsistent indenting

[Yang Li]

Kernel test robot throws below warning ->

smatch warnings:
sound/core/seq/oss/seq_oss_event.c:297 note_on_event() warn:
inconsistent indenting

Fixed the inconsistent indenting.

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
---
 sound/core/seq/oss/seq_oss_event.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/core/seq/oss/seq_oss_event.c b/sound/core/seq/oss/seq_oss_event.c
index 7b7c925..9a42713 100644
--- a/sound/core/seq/oss/seq_oss_event.c
+++ b/sound/core/seq/oss/seq_oss_event.c
@@ -294,7 +294,7 @@
 				/* set volume to zero -- note off */
 			//	type = SNDRV_SEQ_EVENT_NOTEOFF;
 			//else
-				if (info->ch[ch].vel)
+			if (info->ch[ch].vel)
 				/* sample already started -- volume change */
 				type = SNDRV_SEQ_EVENT_KEYPRESS;
 			else
-- 
1.8.3.1

Re: [PATCH] ALSA: seq: oss: Fix inconsistent indenting

[Takashi Iwai]

On Fri, 16 Apr 2021 12:00:44 +0200,
Yang Li wrote:
> 
> Kernel test robot throws below warning ->
> 
> smatch warnings:
> sound/core/seq/oss/seq_oss_event.c:297 note_on_event() warn:
> inconsistent indenting
> 
> Fixed the inconsistent indenting.
> 
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
> ---
>  sound/core/seq/oss/seq_oss_event.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/sound/core/seq/oss/seq_oss_event.c b/sound/core/seq/oss/seq_oss_event.c
> index 7b7c925..9a42713 100644
> --- a/sound/core/seq/oss/seq_oss_event.c
> +++ b/sound/core/seq/oss/seq_oss_event.c
> @@ -294,7 +294,7 @@
>  				/* set volume to zero -- note off */
>  			//	type = SNDRV_SEQ_EVENT_NOTEOFF;
>  			//else
> -				if (info->ch[ch].vel)
> +			if (info->ch[ch].vel)
>  				/* sample already started -- volume change */
>  				type = SNDRV_SEQ_EVENT_KEYPRESS;

The line was aligned with the commented if block.
If any, we should rather clean up and re-format the whole block.
(But, OTOH, you shouldn't remove the stuff without understanding
the context.)


thanks,

Takashi

回复：[PATCH] ALSA: seq: oss: Fix inconsistent indenting

[Yang.Lee]

Thank you for your suggestion. I will revise and submit it according to the context in the future.

yang
------------------------------------------------------------------
发件人：Takashi Iwai <tiwai@suse.de>
发送时间：2021年4月16日(星期五) 18:41
收件人：Yang Li <yang.lee@linux.alibaba.com>
抄　送：perex <perex@perex.cz>; tiwai <tiwai@suse.com>; alsa-devel <alsa-devel@alsa-project.org>; linux-kernel <linux-kernel@vger.kernel.org>
主　题：Re: [PATCH] ALSA: seq: oss: Fix inconsistent indenting


On Fri, 16 Apr 2021 12:00:44 +0200,
Yang Li wrote:
> 
> Kernel test robot throws below warning ->
> 
> smatch warnings:
> sound/core/seq/oss/seq_oss_event.c:297 note_on_event() warn:
> inconsistent indenting
> 
> Fixed the inconsistent indenting.
> 
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
> ---
>  sound/core/seq/oss/seq_oss_event.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/sound/core/seq/oss/seq_oss_event.c b/sound/core/seq/oss/seq_oss_event.c
> index 7b7c925..9a42713 100644
> --- a/sound/core/seq/oss/seq_oss_event.c
> +++ b/sound/core/seq/oss/seq_oss_event.c
> @@ -294,7 +294,7 @@
>      /* set volume to zero -- note off */
>     // type = SNDRV_SEQ_EVENT_NOTEOFF;
>     //else
> -    if (info->ch[ch].vel)
> +   if (info->ch[ch].vel)
>      /* sample already started -- volume change */
>      type = SNDRV_SEQ_EVENT_KEYPRESS;

The line was aligned with the commented if block.
If any, we should rather clean up and re-format the whole block.
(But, OTOH, you shouldn't remove the stuff without understanding
the context.)


thanks,

Takashi