[PATCH] r8152: select CRC32 and CRYPTO/CRYPTO_HASH/CRYPTO_SHA256

[PATCH] r8152: select CRC32 and CRYPTO/CRYPTO_HASH/CRYPTO_SHA256

[Vegard Nossum]

Fix the following build/link errors by adding a dependency on
CRYPTO, CRYPTO_HASH, CRYPTO_SHA256 and CRC32:

  ld: drivers/net/usb/r8152.o: in function `rtl8152_fw_verify_checksum':
  r8152.c:(.text+0x2b2a): undefined reference to `crypto_alloc_shash'
  ld: r8152.c:(.text+0x2bed): undefined reference to `crypto_shash_digest'
  ld: r8152.c:(.text+0x2c50): undefined reference to `crypto_destroy_tfm'
  ld: drivers/net/usb/r8152.o: in function `_rtl8152_set_rx_mode':
  r8152.c:(.text+0xdcb0): undefined reference to `crc32_le'

Signed-off-by: Vegard Nossum <vegard.nossum@oracle.com>
---
 drivers/net/usb/Kconfig | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/net/usb/Kconfig b/drivers/net/usb/Kconfig
index 4c5d69732a7e1..f87f175033731 100644
--- a/drivers/net/usb/Kconfig
+++ b/drivers/net/usb/Kconfig
@@ -99,6 +99,10 @@ config USB_RTL8150
 config USB_RTL8152
 	tristate "Realtek RTL8152/RTL8153 Based USB Ethernet Adapters"
 	select MII
+	select CRC32
+	select CRYPTO
+	select CRYPTO_HASH
+	select CRYPTO_SHA256
 	help
 	  This option adds support for Realtek RTL8152 based USB 2.0
 	  10/100 Ethernet adapters and RTL8153 based USB 3.0 10/100/1000
-- 
2.23.0.718.g5ad94255a8

Re: [PATCH] r8152: select CRC32 and CRYPTO/CRYPTO_HASH/CRYPTO_SHA256

[Vegard Nossum]

On 10/11/21 5:22 PM, Vegard Nossum wrote:
> Fix the following build/link errors by adding a dependency on
> CRYPTO, CRYPTO_HASH, CRYPTO_SHA256 and CRC32:
> 
>   ld: drivers/net/usb/r8152.o: in function `rtl8152_fw_verify_checksum':
>   r8152.c:(.text+0x2b2a): undefined reference to `crypto_alloc_shash'
>   ld: r8152.c:(.text+0x2bed): undefined reference to `crypto_shash_digest'
>   ld: r8152.c:(.text+0x2c50): undefined reference to `crypto_destroy_tfm'
>   ld: drivers/net/usb/r8152.o: in function `_rtl8152_set_rx_mode':
>   r8152.c:(.text+0xdcb0): undefined reference to `crc32_le'
> 

We could also add:

Fixes: 9370f2d05a2a1 ("r8152: support request_firmware for RTL8153")

for the crypto_*() calls and

Fixes: ac718b69301c7 ("net/usb: new driver for RTL8152")

for the crc32_le() call (through ether_crc()).

(Sorry I forgot to add this the first time around.)


Vegard

Re: [PATCH] r8152: select CRC32 and CRYPTO/CRYPTO_HASH/CRYPTO_SHA256

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to netdev/net.git (master)
by David S. Miller <davem@davemloft.net>:

On Mon, 11 Oct 2021 17:22:49 +0200 you wrote:
> Fix the following build/link errors by adding a dependency on
> CRYPTO, CRYPTO_HASH, CRYPTO_SHA256 and CRC32:
> 
>   ld: drivers/net/usb/r8152.o: in function `rtl8152_fw_verify_checksum':
>   r8152.c:(.text+0x2b2a): undefined reference to `crypto_alloc_shash'
>   ld: r8152.c:(.text+0x2bed): undefined reference to `crypto_shash_digest'
>   ld: r8152.c:(.text+0x2c50): undefined reference to `crypto_destroy_tfm'
>   ld: drivers/net/usb/r8152.o: in function `_rtl8152_set_rx_mode':
>   r8152.c:(.text+0xdcb0): undefined reference to `crc32_le'
> 
> [...]

Here is the summary with links:
  - r8152: select CRC32 and CRYPTO/CRYPTO_HASH/CRYPTO_SHA256
    https://git.kernel.org/netdev/net/c/9973a43012b6

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html