* [PATCH net] net: dsa: lantiq_gswip: fix register definition
@ 2021-10-15 22:10 Aleksander Jan Bajkowski
2021-10-16 11:57 ` Hauke Mehrtens
2021-10-18 12:40 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Aleksander Jan Bajkowski @ 2021-10-15 22:10 UTC (permalink / raw)
To: hauke, andrew, vivien.didelot, f.fainelli, olteanv, davem, kuba,
netdev, linux-kernel
Cc: Aleksander Jan Bajkowski
I compared the register definitions with the D-Link DWR-966
GPL sources and found that the PUAFD field definition was
incorrect. This definition is unused and causes no issues.
Fixes: 14fceff4771e ("net: dsa: Add Lantiq / Intel DSA driver for vrx200")
Signed-off-by: Aleksander Jan Bajkowski <olek2@wp.pl>
---
drivers/net/dsa/lantiq_gswip.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/dsa/lantiq_gswip.c b/drivers/net/dsa/lantiq_gswip.c
index 3ff4b7e177f3..dbd4486a173f 100644
--- a/drivers/net/dsa/lantiq_gswip.c
+++ b/drivers/net/dsa/lantiq_gswip.c
@@ -230,7 +230,7 @@
#define GSWIP_SDMA_PCTRLp(p) (0xBC0 + ((p) * 0x6))
#define GSWIP_SDMA_PCTRL_EN BIT(0) /* SDMA Port Enable */
#define GSWIP_SDMA_PCTRL_FCEN BIT(1) /* Flow Control Enable */
-#define GSWIP_SDMA_PCTRL_PAUFWD BIT(1) /* Pause Frame Forwarding */
+#define GSWIP_SDMA_PCTRL_PAUFWD BIT(3) /* Pause Frame Forwarding */
#define GSWIP_TABLE_ACTIVE_VLAN 0x01
#define GSWIP_TABLE_VLAN_MAPPING 0x02
--
2.30.2
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH net] net: dsa: lantiq_gswip: fix register definition
2021-10-15 22:10 [PATCH net] net: dsa: lantiq_gswip: fix register definition Aleksander Jan Bajkowski
@ 2021-10-16 11:57 ` Hauke Mehrtens
2021-10-18 12:40 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Hauke Mehrtens @ 2021-10-16 11:57 UTC (permalink / raw)
To: Aleksander Jan Bajkowski, andrew, vivien.didelot, f.fainelli,
olteanv, davem, kuba, netdev, linux-kernel
On 10/16/21 12:10 AM, Aleksander Jan Bajkowski wrote:
> I compared the register definitions with the D-Link DWR-966
> GPL sources and found that the PUAFD field definition was
> incorrect. This definition is unused and causes no issues.
>
> Fixes: 14fceff4771e ("net: dsa: Add Lantiq / Intel DSA driver for vrx200")
> Signed-off-by: Aleksander Jan Bajkowski <olek2@wp.pl>
Acked-by: Hauke Mehrtens <hauke@hauke-m.de>
Thanks for finding this problem.
> ---
> drivers/net/dsa/lantiq_gswip.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/dsa/lantiq_gswip.c b/drivers/net/dsa/lantiq_gswip.c
> index 3ff4b7e177f3..dbd4486a173f 100644
> --- a/drivers/net/dsa/lantiq_gswip.c
> +++ b/drivers/net/dsa/lantiq_gswip.c
> @@ -230,7 +230,7 @@
> #define GSWIP_SDMA_PCTRLp(p) (0xBC0 + ((p) * 0x6))
> #define GSWIP_SDMA_PCTRL_EN BIT(0) /* SDMA Port Enable */
> #define GSWIP_SDMA_PCTRL_FCEN BIT(1) /* Flow Control Enable */
> -#define GSWIP_SDMA_PCTRL_PAUFWD BIT(1) /* Pause Frame Forwarding */
> +#define GSWIP_SDMA_PCTRL_PAUFWD BIT(3) /* Pause Frame Forwarding */
>
> #define GSWIP_TABLE_ACTIVE_VLAN 0x01
> #define GSWIP_TABLE_VLAN_MAPPING 0x02
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH net] net: dsa: lantiq_gswip: fix register definition
2021-10-15 22:10 [PATCH net] net: dsa: lantiq_gswip: fix register definition Aleksander Jan Bajkowski
2021-10-16 11:57 ` Hauke Mehrtens
@ 2021-10-18 12:40 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2021-10-18 12:40 UTC (permalink / raw)
To: Aleksander Jan Bajkowski
Cc: hauke, andrew, vivien.didelot, f.fainelli, olteanv, davem, kuba,
netdev, linux-kernel
Hello:
This patch was applied to netdev/net.git (master)
by David S. Miller <davem@davemloft.net>:
On Sat, 16 Oct 2021 00:10:20 +0200 you wrote:
> I compared the register definitions with the D-Link DWR-966
> GPL sources and found that the PUAFD field definition was
> incorrect. This definition is unused and causes no issues.
>
> Fixes: 14fceff4771e ("net: dsa: Add Lantiq / Intel DSA driver for vrx200")
> Signed-off-by: Aleksander Jan Bajkowski <olek2@wp.pl>
>
> [...]
Here is the summary with links:
- [net] net: dsa: lantiq_gswip: fix register definition
https://git.kernel.org/netdev/net/c/66d262804a22
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-10-18 12:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-10-15 22:10 [PATCH net] net: dsa: lantiq_gswip: fix register definition Aleksander Jan Bajkowski
2021-10-16 11:57 ` Hauke Mehrtens
2021-10-18 12:40 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox