public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Sameer Pujar <spujar@nvidia.com>
To: <broonie@kernel.org>, <lgirdwood@gmail.com>, <perex@perex.cz>,
	<tiwai@suse.com>
Cc: <thierry.reding@gmail.com>, <jonathanh@nvidia.com>,
	<alsa-devel@alsa-project.org>, <linux-tegra@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, Sameer Pujar <spujar@nvidia.com>
Subject: [PATCH v2 04/10] ASoC: tegra: Fix kcontrol put callback in DSPK
Date: Wed, 3 Nov 2021 19:22:20 +0530	[thread overview]
Message-ID: <1635947547-24391-5-git-send-email-spujar@nvidia.com> (raw)
In-Reply-To: <1635947547-24391-1-git-send-email-spujar@nvidia.com>

The kcontrol put callback is expected to return 1 when there is change
in HW or when the update is acknowledged by driver. This would ensure
that change notifications are sent to subscribed applications. Update
the DSPK driver accordingly.

Fixes: 327ef6470266 ("ASoC: tegra: Add Tegra186 based DSPK driver")
Suggested-by: Jaroslav Kysela <perex@perex.cz>
Suggested-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Sameer Pujar <spujar@nvidia.com>
---
 sound/soc/tegra/tegra186_dspk.c | 33 ++++++++++++++++++++++++++-------
 1 file changed, 26 insertions(+), 7 deletions(-)

diff --git a/sound/soc/tegra/tegra186_dspk.c b/sound/soc/tegra/tegra186_dspk.c
index 8ee9a77..4cc06e9 100644
--- a/sound/soc/tegra/tegra186_dspk.c
+++ b/sound/soc/tegra/tegra186_dspk.c
@@ -55,20 +55,39 @@ static int tegra186_dspk_put_control(struct snd_kcontrol *kcontrol,
 	struct tegra186_dspk *dspk = snd_soc_component_get_drvdata(codec);
 	int val = ucontrol->value.integer.value[0];
 
-	if (strstr(kcontrol->id.name, "FIFO Threshold"))
+	if (strstr(kcontrol->id.name, "FIFO Threshold")) {
+		if (dspk->rx_fifo_th == val)
+			return 0;
+
 		dspk->rx_fifo_th = val;
-	else if (strstr(kcontrol->id.name, "OSR Value"))
+	} else if (strstr(kcontrol->id.name, "OSR Value")) {
+		if (dspk->osr_val == val)
+			return 0;
+
 		dspk->osr_val = val;
-	else if (strstr(kcontrol->id.name, "LR Polarity Select"))
+	} else if (strstr(kcontrol->id.name, "LR Polarity Select")) {
+		if (dspk->lrsel == val)
+			return 0;
+
 		dspk->lrsel = val;
-	else if (strstr(kcontrol->id.name, "Channel Select"))
+	} else if (strstr(kcontrol->id.name, "Channel Select")) {
+		if (dspk->ch_sel == val)
+			return 0;
+
 		dspk->ch_sel = val;
-	else if (strstr(kcontrol->id.name, "Mono To Stereo"))
+	} else if (strstr(kcontrol->id.name, "Mono To Stereo")) {
+		if (dspk->mono_to_stereo == val)
+			return 0;
+
 		dspk->mono_to_stereo = val;
-	else if (strstr(kcontrol->id.name, "Stereo To Mono"))
+	} else if (strstr(kcontrol->id.name, "Stereo To Mono")) {
+		if (dspk->stereo_to_mono == val)
+			return 0;
+
 		dspk->stereo_to_mono = val;
+	}
 
-	return 0;
+	return 1;
 }
 
 static int __maybe_unused tegra186_dspk_runtime_suspend(struct device *dev)
-- 
2.7.4


  parent reply	other threads:[~2021-11-03 13:53 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-03 13:52 [PATCH v2 00/10] Fix kcontrol put callback in Tegra drivers Sameer Pujar
2021-11-03 13:52 ` [PATCH v2 01/10] ASoC: tegra: Fix kcontrol put callback in ADMAIF Sameer Pujar
2021-11-03 14:16   ` Takashi Iwai
2021-11-03 14:18     ` Takashi Iwai
2021-11-03 17:25     ` Jaroslav Kysela
2021-11-08 16:03       ` Sameer Pujar
2021-11-08 16:16         ` Mark Brown
2021-11-08 16:08     ` Sameer Pujar
2021-11-03 13:52 ` [PATCH v2 02/10] ASoC: tegra: Fix kcontrol put callback in I2S Sameer Pujar
2021-11-03 13:52 ` [PATCH v2 03/10] ASoC: tegra: Fix kcontrol put callback in DMIC Sameer Pujar
2021-11-03 13:52 ` Sameer Pujar [this message]
2021-11-03 13:52 ` [PATCH v2 05/10] ASoC: tegra: Fix kcontrol put callback in AHUB Sameer Pujar
2021-11-03 13:52 ` [PATCH v2 06/10] ASoC: tegra: Fix kcontrol put callback in MVC Sameer Pujar
2021-11-03 13:52 ` [PATCH v2 07/10] ASoC: tegra: Fix kcontrol put callback in SFC Sameer Pujar
2021-11-03 13:52 ` [PATCH v2 08/10] ASoC: tegra: Fix kcontrol put callback in AMX Sameer Pujar
2021-11-03 13:52 ` [PATCH v2 09/10] ASoC: tegra: Fix kcontrol put callback in ADX Sameer Pujar
2021-11-03 13:52 ` [PATCH v2 10/10] ASoC: tegra: Fix kcontrol put callback in Mixer Sameer Pujar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1635947547-24391-5-git-send-email-spujar@nvidia.com \
    --to=spujar@nvidia.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=jonathanh@nvidia.com \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=thierry.reding@gmail.com \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox