From: Sameer Pujar <spujar@nvidia.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: broonie@kernel.org, lgirdwood@gmail.com, perex@perex.cz,
tiwai@suse.com, thierry.reding@gmail.com, jonathanh@nvidia.com,
alsa-devel@alsa-project.org, linux-tegra@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 01/10] ASoC: tegra: Fix kcontrol put callback in ADMAIF
Date: Mon, 8 Nov 2021 21:38:45 +0530 [thread overview]
Message-ID: <418e4db8-4572-3e29-fb5d-e4c23280a5cc@nvidia.com> (raw)
In-Reply-To: <s5ha6ilmiiv.wl-tiwai@suse.de>
On 11/3/2021 7:46 PM, Takashi Iwai wrote:
> BTW, independent from this patch set, I noticed that those get/put
> callbacks handle the wrong type. For enum ctls, you have to use
> ucontrol->value.enumerated.value instead of
> ucontrol->value.integer.value. The former is long while the latter is
> int, hence they may have different sizes.
>
> Such a bug could be caught if you test once with
> CONFIG_SND_CTL_VALIDATION=y. It's recommended to test with that
> config once for a new driver code.
>
> So, please submit the fix patch(es) for correcting the ctl value
> types, too.
Thanks for suggesting. I will include fixes for this as well in current
series.
next prev parent reply other threads:[~2021-11-08 16:09 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-03 13:52 [PATCH v2 00/10] Fix kcontrol put callback in Tegra drivers Sameer Pujar
2021-11-03 13:52 ` [PATCH v2 01/10] ASoC: tegra: Fix kcontrol put callback in ADMAIF Sameer Pujar
2021-11-03 14:16 ` Takashi Iwai
2021-11-03 14:18 ` Takashi Iwai
2021-11-03 17:25 ` Jaroslav Kysela
2021-11-08 16:03 ` Sameer Pujar
2021-11-08 16:16 ` Mark Brown
2021-11-08 16:08 ` Sameer Pujar [this message]
2021-11-03 13:52 ` [PATCH v2 02/10] ASoC: tegra: Fix kcontrol put callback in I2S Sameer Pujar
2021-11-03 13:52 ` [PATCH v2 03/10] ASoC: tegra: Fix kcontrol put callback in DMIC Sameer Pujar
2021-11-03 13:52 ` [PATCH v2 04/10] ASoC: tegra: Fix kcontrol put callback in DSPK Sameer Pujar
2021-11-03 13:52 ` [PATCH v2 05/10] ASoC: tegra: Fix kcontrol put callback in AHUB Sameer Pujar
2021-11-03 13:52 ` [PATCH v2 06/10] ASoC: tegra: Fix kcontrol put callback in MVC Sameer Pujar
2021-11-03 13:52 ` [PATCH v2 07/10] ASoC: tegra: Fix kcontrol put callback in SFC Sameer Pujar
2021-11-03 13:52 ` [PATCH v2 08/10] ASoC: tegra: Fix kcontrol put callback in AMX Sameer Pujar
2021-11-03 13:52 ` [PATCH v2 09/10] ASoC: tegra: Fix kcontrol put callback in ADX Sameer Pujar
2021-11-03 13:52 ` [PATCH v2 10/10] ASoC: tegra: Fix kcontrol put callback in Mixer Sameer Pujar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=418e4db8-4572-3e29-fb5d-e4c23280a5cc@nvidia.com \
--to=spujar@nvidia.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=jonathanh@nvidia.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=perex@perex.cz \
--cc=thierry.reding@gmail.com \
--cc=tiwai@suse.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox