[PATCH] ethtool: netlink: Slightly simplify 'ethnl_features_to_bitmap()'

[PATCH] ethtool: netlink: Slightly simplify 'ethnl_features_to_bitmap()'

[Christophe JAILLET]

The 'dest' bitmap is fully initialized by the 'for' loop, so there is no
need to explicitly reset it.

This also makes this function in line with 'ethnl_features_to_bitmap32()'
which does not clear the destination before writing it.

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
 net/ethtool/features.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/net/ethtool/features.c b/net/ethtool/features.c
index 1c9f4df273bd..2e7331b23996 100644
--- a/net/ethtool/features.c
+++ b/net/ethtool/features.c
@@ -136,7 +136,6 @@ static void ethnl_features_to_bitmap(unsigned long *dest, netdev_features_t val)
 	const unsigned int words = BITS_TO_LONGS(NETDEV_FEATURE_COUNT);
 	unsigned int i;
 
-	bitmap_zero(dest, NETDEV_FEATURE_COUNT);
 	for (i = 0; i < words; i++)
 		dest[i] = (unsigned long)(val >> (i * BITS_PER_LONG));
 }
-- 
2.30.2

Re: [PATCH] ethtool: netlink: Slightly simplify 'ethnl_features_to_bitmap()'

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to netdev/net-next.git (master)
by Jakub Kicinski <kuba@kernel.org>:

On Sun, 28 Nov 2021 12:03:30 +0100 you wrote:
> The 'dest' bitmap is fully initialized by the 'for' loop, so there is no
> need to explicitly reset it.
> 
> This also makes this function in line with 'ethnl_features_to_bitmap32()'
> which does not clear the destination before writing it.
> 
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> 
> [...]

Here is the summary with links:
  - ethtool: netlink: Slightly simplify 'ethnl_features_to_bitmap()'
    https://git.kernel.org/netdev/net-next/c/72a2ff567fc3

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html