[PATCH v2] sfc_ef100: potential dereference of null pointer

[PATCH v2] sfc_ef100: potential dereference of null pointer

[Jiasheng Jiang]

The return value of kmalloc() needs to be checked.
To avoid use in efx_nic_update_stats() in case of the failure of alloc.

Fixes: b593b6f1b492 ("sfc_ef100: statistics gathering")
Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
Reported-by: kernel test robot <lkp@intel.com>
---
Changelog:

v1 -> v2

*Change 1. Change the place to check, avoiding the warning.
---
 drivers/net/ethernet/sfc/ef100_nic.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/net/ethernet/sfc/ef100_nic.c b/drivers/net/ethernet/sfc/ef100_nic.c
index 518268ce2064..d35cafd422b1 100644
--- a/drivers/net/ethernet/sfc/ef100_nic.c
+++ b/drivers/net/ethernet/sfc/ef100_nic.c
@@ -609,6 +609,9 @@ static size_t ef100_update_stats(struct efx_nic *efx,
 	ef100_common_stat_mask(mask);
 	ef100_ethtool_stat_mask(mask);
 
+	if (!mc_stats)
+		return 0;
+
 	efx_nic_copy_stats(efx, mc_stats);
 	efx_nic_update_stats(ef100_stat_desc, EF100_STAT_COUNT, mask,
 			     stats, mc_stats, false);
-- 
2.25.1

Re: [PATCH v2] sfc_ef100: potential dereference of null pointer

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to netdev/net.git (master)
by David S. Miller <davem@davemloft.net>:

On Wed, 15 Dec 2021 22:37:31 +0800 you wrote:
> The return value of kmalloc() needs to be checked.
> To avoid use in efx_nic_update_stats() in case of the failure of alloc.
> 
> Fixes: b593b6f1b492 ("sfc_ef100: statistics gathering")
> Signed-off-by: Jiasheng Jiang <jiasheng@iscas.ac.cn>
> Reported-by: kernel test robot <lkp@intel.com>
> 
> [...]

Here is the summary with links:
  - [v2] sfc_ef100: potential dereference of null pointer
    https://git.kernel.org/netdev/net/c/407ecd1bd726

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html